-
Notifications
You must be signed in to change notification settings - Fork 131
8358538: Update GHA Windows runner to 2025 #1853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8358538: Update GHA Windows runner to 2025 #1853
Conversation
👋 Welcome back shade! A progress list of the required criteria for merging this PR into |
@shipilev This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 66 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
This backport pull request has now been updated with issue from the original commit. |
|
Webrevs
|
Of course there are build failures. And of course they are confusing:
Exactly the same code compiles fine in mainline... |
The one difference I see between the 21u and trunk version is the lack of It might be worth trying 24u and seeing if it fails in the same way, though not worth fixing this there at this point in its lifecycle. |
I actually tried both |
Bad news: compile error looks like a MSVC bug. Good news: I think MSVC |
/issue add JDK-8360042 |
@shipilev |
All right, this seems to work fairly well. I am going to trigger some repeated GHA runs for this PR. Meanwhile, I am going to ask for approvals. Then 17u and 11u backports may follow the same pattern. |
/approval 8358538 request Switches GHA Windows runners to the ones available past June 2025. Applies cleanly, but requires JDK-8360042 to work with current runner images. GHA testing passes. Risk/benefit is low: GHA-only change, the runners are already browning-out, would completely fail in a week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine. Thanks for going through this.
/approve yes |
@jerboaa |
All right, here goes! /integrate |
Going to push as commit 10929bd.
Your commit was automatically rebased without conflicts. |
Fixes GHA. Current Windows runners are already in brown-out stage, and will be decommissioned by the end of the month. So we need to get it into update repos soon.
Additional testing:
Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1853/head:pull/1853
$ git checkout pull/1853
Update a local copy of the PR:
$ git checkout pull/1853
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1853/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1853
View PR using the GUI difftool:
$ git pr show -t 1853
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1853.diff
Using Webrev
Link to Webrev Comment