-
Notifications
You must be signed in to change notification settings - Fork 131
8332020: jwebserver tool prints invalid URL in case of IPv6 address binding #1980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
8332020: jwebserver tool prints invalid URL in case of IPv6 address binding #1980
Conversation
👋 Welcome back tkurashige! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
This backport pull request has now been updated with issue from the original commit. |
|
/approval request Backporting this patch eliminates the problem that jwebserver prints invalid URL. |
@kurashige23 |
@kurashige23 I had a look at this yesterday for approval. Could you explain the relationship this has with #1981? They seem unrelated and while I tend to think approval of this one is ok, the depending one isn't necessarily unless you can explain what it actually fixes and why this is an issue now. Thanks! |
Hi,
This is a backoport of JDK-8332020: jwebserver tool prints invalid URL in case of IPv6 address binding
Original patch applies cleanly to 21u.
Testing: test/jdk/com/sun/net/httpserver/simpleserver passes on Windows Server 2022
Thanks.
Progress
Warning
8332020: jwebserver tool prints invalid URL in case of IPv6 address binding
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1980/head:pull/1980
$ git checkout pull/1980
Update a local copy of the PR:
$ git checkout pull/1980
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1980/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1980
View PR using the GUI difftool:
$ git pr show -t 1980
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1980.diff
Using Webrev
Link to Webrev Comment