Skip to content

8332020: jwebserver tool prints invalid URL in case of IPv6 address binding #1980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kurashige23
Copy link
Member

@kurashige23 kurashige23 commented Jul 16, 2025

Hi,

This is a backoport of JDK-8332020: jwebserver tool prints invalid URL in case of IPv6 address binding

Original patch applies cleanly to 21u.

Testing: test/jdk/com/sun/net/httpserver/simpleserver passes on Windows Server 2022

Thanks.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8332020 needs maintainer approval

Warning

 ⚠️ Found leading lowercase letter in issue title for 8332020: jwebserver tool prints invalid URL in case of IPv6 address binding

Issue

  • JDK-8332020: jwebserver tool prints invalid URL in case of IPv6 address binding (Bug - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1980/head:pull/1980
$ git checkout pull/1980

Update a local copy of the PR:
$ git checkout pull/1980
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1980/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1980

View PR using the GUI difftool:
$ git pr show -t 1980

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1980.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 16, 2025

👋 Welcome back tkurashige! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 16, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport f9a1d3381b12c97784c11649be079147c85939c0 8332020: jwebserver tool prints invalid URL in case of IPv6 address binding Jul 16, 2025
@openjdk
Copy link

openjdk bot commented Jul 16, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Jul 16, 2025
@openjdk
Copy link

openjdk bot commented Jul 16, 2025

⚠️ @kurashige23 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 16, 2025
@mlbridge
Copy link

mlbridge bot commented Jul 16, 2025

Webrevs

@kurashige23
Copy link
Member Author

/approval request Backporting this patch eliminates the problem that jwebserver prints invalid URL.
This backport includes bug fix and test adding.
Risk is low: affects the use of IPv6 address in the simplewebserver
test/jdk/com/sun/net/httpserver/simpleserver passes on Windows Server 2022.
Clean backport.

@openjdk
Copy link

openjdk bot commented Jul 16, 2025

@kurashige23
8332020: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Jul 16, 2025
@jerboaa
Copy link
Contributor

jerboaa commented Jul 18, 2025

@kurashige23 I had a look at this yesterday for approval. Could you explain the relationship this has with #1981? They seem unrelated and while I tend to think approval of this one is ok, the depending one isn't necessarily unless you can explain what it actually fixes and why this is an issue now. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants