8369085: RichTextArea SELECT_PARAGRAPH to include line separator

[andy-goryachev-oracle]

RichTextArea.Tag.SELECT_PARAGRAPH or RichTextArea.selectParagraph() must include the trailing line separator (if present).

This is a behavioral change, but a simple one (an obvious bug) - maybe one reviewer is sufficient. I don't think this needs a CSR.

Some interdependency exists between this PR and #1944.
Depending which gets integrated first, changes in tests will be needed.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8369085: RichTextArea SELECT_PARAGRAPH to include line separator (Bug - P4)

Reviewers

• Kevin Rushforth (@kevinrushforth - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1940/head:pull/1940
$ git checkout pull/1940

Update a local copy of the PR:
$ git checkout pull/1940
$ git pull https://git.openjdk.org/jfx.git pull/1940/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1940

View PR using the GUI difftool:
$ git pr show -t 1940

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1940.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back angorya! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@andy-goryachev-oracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8369085: RichTextArea SELECT_PARAGRAPH to include line separator

Reviewed-by: kcr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 00: Full (288a9203)

[kevinrushforth]

I agree that this doesn't need a CSR. It seems a simple enough fix, but if @Ziad-Mid could test it that would help (or you can wait for me or @arapte to do it).

[kevinrushforth]

Will this work if you select the last paragraph in the RTA? You'll be calling TextPos.ofLeading with a paragraph index that is out of range, but maybe it handles it?

I see you added a test for just this case. Good.

[kevinrushforth]

LGTM. The newly added test fails without the fix and passes with the fix. Also, it does what I expect in MonkeyTester.

[kevinrushforth]

This is a simple enough fix that a single reviewer is sufficient.

[andy-goryachev-oracle]

thank you!
/integrate

[openjdk]

Going to push as commit 42fd4eb.

[openjdk]

@andy-goryachev-oracle Pushed as commit 42fd4eb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.