Skip to content

8369085: RichTextArea SELECT_PARAGRAPH to include line separator #1940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

8369085: RichTextArea SELECT_PARAGRAPH to include line separator #1940

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...text/src/main/java/com/sun/jfx/incubator/scene/control/richtext/RichTextAreaBehavior.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -910,7 +910,7 @@ public void selectParagraph() {
if (p != null) {
int ix = p.index();
TextPos an = TextPos.ofLeading(ix, 0);
TextPos ca = control.getParagraphEnd(ix);
TextPos ca = TextPos.ofLeading(ix + 1, 0);
Copy link
Member

@kevinrushforth kevinrushforth Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this work if you select the last paragraph in the RTA? You'll be calling TextPos.ofLeading with a paragraph index that is out of range, but maybe it handles it?

I see you added a test for just this case. Good.

control.select(an, ca);
}
}
Expand Down
17 changes: 17 additions & 0 deletions ...or.richtext/src/test/java/test/jfx/incubator/scene/control/richtext/RichTextAreaTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -642,6 +642,23 @@ public void selectAll() {
assertEquals(end, sel.getMax());
}

@Test
public void selectParagraph() {
control.appendText("123\n456\n789");
// first line
control.select(TextPos.ZERO);
control.selectParagraph();
SelectionSegment sel = control.getSelection();
assertEquals(TextPos.ZERO, sel.getMin());
assertEquals(TextPos.ofLeading(1, 0), sel.getMax());
// last line, no trailing line separator
control.select(TextPos.ofLeading(2, 0));
control.selectParagraph();
sel = control.getSelection();
assertEquals(TextPos.ofLeading(2, 0), sel.getMin());
assertEquals(new TextPos(2, 3, 2, false), sel.getMax());
}

@Test
public void undo() {
control.appendText("1");
Expand Down