8370140: RichTextArea: line endings #1944
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds control of line endings (newline separators) in
StyledTextModel,RichTextArea, andCodeArea.The impacted areas are:
This feature is implemented as a regular field in the
StyledTextModel(since it is ultimately an attribute of the model), and as a property in theCodeArea.Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1944/head:pull/1944$ git checkout pull/1944Update a local copy of the PR:
$ git checkout pull/1944$ git pull https://git.openjdk.org/jfx.git pull/1944/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1944View PR using the GUI difftool:
$ git pr show -t 1944Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1944.diff
Using Webrev
Link to Webrev Comment