Skip to content

Conversation

@andy-goryachev-oracle
Copy link
Contributor

@andy-goryachev-oracle andy-goryachev-oracle commented Oct 22, 2025

Adds control of line endings (newline separators) in StyledTextModel, RichTextArea, and CodeArea.

The impacted areas are:

  • saving to plain text
  • copying to plain text

This feature is implemented as a regular field in the StyledTextModel (since it is ultimately an attribute of the model), and as a property in the CodeArea.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires a CSR request matching fixVersion jfx26 to be approved (needs to be created)
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

  • JDK-8370140: RichTextArea: line endings (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1944/head:pull/1944
$ git checkout pull/1944

Update a local copy of the PR:
$ git checkout pull/1944
$ git pull https://git.openjdk.org/jfx.git pull/1944/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1944

View PR using the GUI difftool:
$ git pr show -t 1944

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1944.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 22, 2025

👋 Welcome back angorya! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 22, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@andy-goryachev-oracle
Copy link
Contributor Author

/reviewers 2
/csr

@openjdk openjdk bot added the rfr Ready for review label Oct 22, 2025
@openjdk
Copy link

openjdk bot commented Oct 22, 2025

@andy-goryachev-oracle
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

@openjdk openjdk bot added the csr Need approved CSR to integrate pull request label Oct 22, 2025
@openjdk
Copy link

openjdk bot commented Oct 22, 2025

@andy-goryachev-oracle has indicated that a compatibility and specification (CSR) request is needed for this pull request.

@andy-goryachev-oracle please create a CSR request for issue JDK-8370140 with the correct fix version. This pull request cannot be integrated until the CSR request is approved.

@mlbridge
Copy link

mlbridge bot commented Oct 22, 2025

Webrevs

@kevinrushforth kevinrushforth self-requested a review October 23, 2025 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

csr Need approved CSR to integrate pull request rfr Ready for review

Development

Successfully merging this pull request may close these issues.

1 participant