7904104: intermittent test failure in TimeoutDefaultSecondsWaiter

[vpa1977]

victim.interrupt() is not needed if the process exits after the kill signal.
This PR only calls interrupt() if the process fails to exit or the wait is interrupted for some reason.

This allows TimeoutDefaultSecondsWaiter tests to pass.

Alternative: update assertion in TimeoutDefaultSecondsWaiter test.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• CODETOOLS-7904104: intermittent test failure in TimeoutDefaultSecondsWaiter (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jtreg.git pull/296/head:pull/296
$ git checkout pull/296

Update a local copy of the PR:
$ git checkout pull/296
$ git pull https://git.openjdk.org/jtreg.git pull/296/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 296

View PR using the GUI difftool:
$ git pr show -t 296

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jtreg/pull/296.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back vpetko! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[mlbridge]

Webrevs

• 00: Full (f893ba6b)

[bridgekeeper]

@vpa1977 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[vpa1977]

/touch

[openjdk]

@vpa1977 The pull request is being re-evaluated and the inactivity timeout has been reset.

[sormuras]

@jonathan-gibbons and others correct me if I'm reading the comment in src/share/classes/com/sun/javatest/regtest/exec/ProcessCommand.java wrong,

// JDK 1.8 introduces a Process.waitFor(timeout) method which could
// be used here. We need run on 1.5 so using interrupt() instead.

victim.interrupt();

but here it is about to replace:

int exitCode = process.waitFor(); in ProcessCommand.java#L280

with

int exitCode = process.waitFor(TIMEOUT);

and remove the custom "victim" timeout thread entirely. Right?

[vpa1977]

and remove the custom "victim" timeout thread entirely. Right?

It may still be needed for the edge condition where the process does not exit within the specified timeout[1]. In this case we want to unlock the main thread to continue with the next test.

[1] https://docs.oracle.com/javase/8/docs/api/java/lang/Process.html#waitFor-long-java.util.concurrent.TimeUnit-