Skip to content

feat: add config flag support for deploy, preview, and upload commands #762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

0ta-mjn
Copy link

@0ta-mjn 0ta-mjn commented Jul 3, 2025

Based on #761

Copy link

changeset-bot bot commented Jul 3, 2025

⚠️ No Changeset found

Latest commit: e0f39b6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vicb
Copy link
Contributor

vicb commented Jul 3, 2025

Thanks for the issue and PR @0ta-mjn

@james-elicx can you please review?

@vicb vicb requested a review from james-elicx July 3, 2025 12:43
* @param args - CLI arguments.
* @returns Value of the config flag.
*/
export function getWranglerConfigFlag(args: string[]) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we should create a factory function taking the short and long names two factor code across those last 2 functions?

Copy link
Collaborator

@james-elicx james-elicx Jul 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, I had the same thought as well

@vicb
Copy link
Contributor

vicb commented Jul 7, 2025

I have a different implementation in #768 where we now retrieve the wrangler config earlier and pass it to the commands

@vicb vicb mentioned this pull request Jul 8, 2025
@vicb
Copy link
Contributor

vicb commented Jul 8, 2025

In the end I had to revert the changes I did regarding the config in #768

But I created #770 to try to cleanup the way we handle commands

@vicb
Copy link
Contributor

vicb commented Jul 8, 2025

@0ta-mjn regaring my latest message, I think the cleanup might take some time to land.

Maybe you can rebase your PR on top of #768 once it lands (hopefully soon) so that we a have an interim solution.

@0ta-mjn
Copy link
Author

0ta-mjn commented Jul 9, 2025

@vicb Thanks for the heads-up!
Sounds good! I'll keep an eye on #768 and rebase my PR as soon as it lands.

@vicb
Copy link
Contributor

vicb commented Jul 9, 2025

@vicb Thanks for the heads-up! Sounds good! I'll keep an eye on #768 and rebase my PR as soon as it lands.

Thanks!

The PR was merged.

I guess the main change you'll need to do is to use https://github.com/opennextjs/opennextjs-cloudflare/pull/768/files#diff-bd8a4f60544321df03ee5dd39591e77190dd5df249b81ef9b49dfb0f3c941059R140

@vicb
Copy link
Contributor

vicb commented Jul 9, 2025

Sorry for the back and forth but please wait for #746 to be merged as well.

@vicb vicb marked this pull request as draft July 11, 2025 11:43
@0ta-mjn 0ta-mjn closed this Jul 15, 2025
@0ta-mjn 0ta-mjn force-pushed the feat/add_config_options_to_populatecache_command branch from 3ab5680 to e0f39b6 Compare July 15, 2025 11:14
@0ta-mjn
Copy link
Author

0ta-mjn commented Jul 15, 2025

@vicb I accidentally closed this pull request while cleaning up my branch. The same changes are now available in #790 . Please continue the review there. Thanks for your understanding!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants