Skip to content

test: add the mock_async_routine #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2025

Conversation

ziccardi
Copy link
Contributor

@ziccardi ziccardi commented Apr 9, 2025

Add the mock_async_routine so tests can be written to use the routine mock
Add a new make target to generate the mocks

@ziccardi
Copy link
Contributor Author

ziccardi commented Apr 9, 2025

@etabak PTAL

@tzvatot
Copy link
Contributor

tzvatot commented Apr 10, 2025

Pending #9 to make sure pipeline is passing after this change.

@tzvatot
Copy link
Contributor

tzvatot commented Apr 15, 2025

@ziccardi would you be able to resolve conflicts with this MR?

Add the mock_async_routine so tests can be written to use the routine mock
@ziccardi ziccardi force-pushed the MOCK_ASYNC_ROUTINE branch from edd2c89 to 33011d9 Compare April 15, 2025 12:50
@ziccardi
Copy link
Contributor Author

@ziccardi would you be able to resolve conflicts with this MR?

@tzvatot Done!

@tzvatot
Copy link
Contributor

tzvatot commented Apr 15, 2025

LGTM

@tzvatot tzvatot merged commit 04d4d0e into openshift-online:main Apr 15, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants