Skip to content

CONSOLE-4573: Improve getting started message #15044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

TheRealJon
Copy link
Member

@TheRealJon TheRealJon commented May 9, 2025

I noticed the getting started message was looking a bit drab...

Before
screencapture-console-openshift-console-apps-ci-ln-24q3stk-1d09d-ci-azure-devcluster-openshift-k8s-cluster-projects-2025-05-09-13_47_35
screencapture-console-openshift-console-apps-ci-ln-24q3stk-1d09d-ci-azure-devcluster-openshift-search-all-namespaces-2025-05-09-13_49_10

After
screencapture-localhost-9000-k8s-cluster-projects-2025-05-14-09_11_12

screencapture-localhost-9000-search-all-namespaces-2025-05-14-09_11_52

@kevinhatchoua @jhadvig WDYT?

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 9, 2025
@openshift-ci-robot
Copy link
Contributor

@TheRealJon: This pull request explicitly references no jira issue.

In response to this:

I noticed the getting started message was looking a bit drab...

Before
screencapture-console-openshift-console-apps-ci-ln-24q3stk-1d09d-ci-azure-devcluster-openshift-k8s-cluster-projects-2025-05-09-13_47_35
screencapture-console-openshift-console-apps-ci-ln-24q3stk-1d09d-ci-azure-devcluster-openshift-search-all-namespaces-2025-05-09-13_49_10

After
screencapture-localhost-9000-k8s-cluster-projects-2025-05-09-13_48_42
screencapture-localhost-9000-search-all-namespaces-2025-05-09-13_49_29

@kevinhatchoua @jhadvig WDYT?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from cajieh and kyoto May 9, 2025 17:55
@openshift-ci openshift-ci bot added component/core Related to console core functionality component/shared Related to console-shared approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 9, 2025
@TheRealJon TheRealJon force-pushed the improve-getting-started branch from 6777da6 to e43ca23 Compare May 9, 2025 18:26
@openshift-ci openshift-ci bot added the kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated label May 9, 2025
Copy link
Member

@logonoff logonoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

one nit

@TheRealJon TheRealJon force-pushed the improve-getting-started branch from e43ca23 to cd00445 Compare May 12, 2025 14:51
Copy link
Member

@logonoff logonoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

we can address the old OpenShift logo issue upstream

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 12, 2025
Copy link
Contributor

openshift-ci bot commented May 12, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff, TheRealJon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 13, 2025
Copy link
Contributor

openshift-ci bot commented May 13, 2025

New changes are detected. LGTM label has been removed.

@TheRealJon TheRealJon changed the title NO-JIRA: Improve getting started message CONSOLE-4573: Improve getting started message May 13, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 13, 2025

@TheRealJon: This pull request references CONSOLE-4573 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

I noticed the getting started message was looking a bit drab...

Before
screencapture-console-openshift-console-apps-ci-ln-24q3stk-1d09d-ci-azure-devcluster-openshift-k8s-cluster-projects-2025-05-09-13_47_35
screencapture-console-openshift-console-apps-ci-ln-24q3stk-1d09d-ci-azure-devcluster-openshift-search-all-namespaces-2025-05-09-13_49_10

After
screencapture-localhost-9000-k8s-cluster-projects-2025-05-13-16_07_02
screencapture-localhost-9000-search-all-namespaces-2025-05-13-16_09_09

@kevinhatchoua @jhadvig WDYT?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@TheRealJon
Copy link
Member Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 13, 2025

@TheRealJon: This pull request references CONSOLE-4573 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@TheRealJon
Copy link
Member Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 13, 2025

@TheRealJon: This pull request references CONSOLE-4573 which is a valid jira issue.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@TheRealJon TheRealJon force-pushed the improve-getting-started branch from 4fe725b to cbaaf34 Compare May 13, 2025 20:22
@TheRealJon TheRealJon force-pushed the improve-getting-started branch from cbaaf34 to b487f43 Compare May 14, 2025 12:46
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 14, 2025

@TheRealJon: This pull request references CONSOLE-4573 which is a valid jira issue.

In response to this:

I noticed the getting started message was looking a bit drab...

Before
screencapture-console-openshift-console-apps-ci-ln-24q3stk-1d09d-ci-azure-devcluster-openshift-k8s-cluster-projects-2025-05-09-13_47_35
screencapture-console-openshift-console-apps-ci-ln-24q3stk-1d09d-ci-azure-devcluster-openshift-search-all-namespaces-2025-05-09-13_49_10

After
screencapture-localhost-9000-k8s-cluster-projects-2025-05-14-09_11_12

screencapture-localhost-9000-search-all-namespaces-2025-05-14-09_11_52

@kevinhatchoua @jhadvig WDYT?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@kevinhatchoua
Copy link

@TheRealJon This looks great! Thanks for making these improvements, as they better align with PatternFly guidelines and recommendations! https://www.patternfly.org/components/empty-state/design-guidelines

Copy link
Contributor

openshift-ci bot commented May 14, 2025

@TheRealJon: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/shared Related to console-shared jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants