OCPBUGS-61465: Add a new field Mapped into openshift-test extension Image struct #2447

dinhxuanvu · 2025-09-04T16:11:04Z

The current GetMappedImageConfigs returns the map with only mapped image config. The new func GetImageConfigsWithMappedImage will return original image information along with mapped one.

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

openshift-ci-robot · 2025-09-04T16:11:16Z

@dinhxuanvu: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

04ebfde|Add a new func to return ImageConfig with a new mapped image field: does not specify an upstream backport in the commit message

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

openshift-ci · 2025-09-04T16:11:59Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dinhxuanvu
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

DOWNSTREAM_OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

dinhxuanvu · 2025-09-04T16:12:09Z

@bertinatto PTAL

test/utils/image/manifest.go

openshift-ci-robot · 2025-09-10T15:29:51Z

@dinhxuanvu: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

ceed810|Add a new field Mapped into openshift-test extension Image struct: does not specify an upstream backport in the commit message

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

dinhxuanvu · 2025-09-10T15:31:02Z

@bertinatto PTAL. Let me know if this looks more like what you have in mind. Also, I assume we are gonna make changes on extension package directly to openshift-tests-extension repo instead of here?

dinhxuanvu · 2025-09-15T13:23:44Z

@stbenjam PTAL

bertinatto

This currently doesn't only set the new field, but it overrides the original struct as well.

openshift-ci-robot · 2025-09-17T03:59:21Z

@dinhxuanvu: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

473fe21|Add a new field Mapped into openshift-test extension Image struct: does not specify an upstream backport in the commit message

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

dinhxuanvu · 2025-09-17T04:00:54Z

@bertinatto @stbenjam @smg247 PTAL

openshift-hack/cmd/k8s-tests-ext/k8s-tests.go

openshift-ci-robot · 2025-09-17T16:13:23Z

@dinhxuanvu: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

feac727|Add a new field Mapped into openshift-test extension Image struct: does not specify an upstream backport in the commit message

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

openshift-ci-robot · 2025-09-17T16:14:16Z

@dinhxuanvu: This pull request references Jira Issue OCPBUGS-61465, which is invalid:

expected the bug to target the "4.21.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

The current GetMappedImageConfigs returns the map with only mapped image config. The new func GetImageConfigsWithMappedImage will return original image information along with mapped one.

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-hack/cmd/k8s-tests-ext/k8s-tests.go

The new field Mapped contains all the same fields of Image resource that can be used later for openshift-tests images cmd to parse this Mapped key. The k8s-tests-ext will construct this Mapped key from GetMappedImageConfigs() function from upstream. Signed-off-by: Vu Dinh <[email protected]>

openshift-ci-robot · 2025-09-17T17:05:26Z

@dinhxuanvu: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

370a1bf|Add a new field Mapped into openshift-test extension Image struct: does not specify an upstream backport in the commit message

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

dinhxuanvu · 2025-09-17T17:06:04Z

/jira refresh

openshift-ci-robot · 2025-09-17T17:06:13Z

@dinhxuanvu: This pull request references Jira Issue OCPBUGS-61465, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.21.0) matches configured target version for branch (4.21.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @wangke19

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2025-09-17T23:19:57Z

@dinhxuanvu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn-runc	`370a1bf`	link	true	`/test e2e-aws-ovn-runc`
ci/prow/okd-scos-e2e-aws-ovn	`370a1bf`	link	false	`/test okd-scos-e2e-aws-ovn`
ci/prow/e2e-aws-ovn-serial	`370a1bf`	link	true	`/test e2e-aws-ovn-serial`
ci/prow/verify	`370a1bf`	link	true	`/test verify`
ci/prow/e2e-gcp	`370a1bf`	link	true	`/test e2e-gcp`
ci/prow/e2e-aws-ovn-techpreview-serial	`370a1bf`	link	false	`/test e2e-aws-ovn-techpreview-serial`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

bertinatto · 2025-09-18T17:00:41Z

openshift-hack/cmd/k8s-tests-ext/k8s-tests.go

+	for k, v := range originals {
+		image := convertToImage(v, int(k))
+		mappedImage := convertToImage(mapped[k], int(k))
+		image.Mapped = &mappedImage


LGTM, we just need to merge the OTE changes first.

The OTE PR is ready for merge. openshift-eng/openshift-tests-extension#40

openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Sep 4, 2025

dinhxuanvu changed the title ~~Add a new func to return ImageConfig with a new mapped image field~~ [WIP] Add a new func to return ImageConfig with a new mapped image field Sep 4, 2025

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 4, 2025

openshift-ci bot requested review from p0lyn0mial and tkashem September 4, 2025 16:11

bertinatto reviewed Sep 8, 2025

View reviewed changes

test/utils/image/manifest.go Outdated Show resolved Hide resolved

dinhxuanvu force-pushed the mapped-image branch from 04ebfde to ceed810 Compare September 10, 2025 15:29

openshift-ci bot added the vendor-update Touching vendor dir or related files label Sep 10, 2025

dinhxuanvu changed the title ~~[WIP] Add a new func to return ImageConfig with a new mapped image field~~ [WIP] Add a new field Mapped into openshift-test extension Image struct Sep 10, 2025

bertinatto reviewed Sep 16, 2025

View reviewed changes

dinhxuanvu force-pushed the mapped-image branch from ceed810 to 473fe21 Compare September 17, 2025 03:59

dinhxuanvu mentioned this pull request Sep 17, 2025

Add Mapped field to Image struct openshift-eng/openshift-tests-extension#40

Open

bertinatto reviewed Sep 17, 2025

View reviewed changes

openshift-hack/cmd/k8s-tests-ext/k8s-tests.go Show resolved Hide resolved

dinhxuanvu force-pushed the mapped-image branch from 473fe21 to feac727 Compare September 17, 2025 16:13

dinhxuanvu changed the title ~~[WIP] Add a new field Mapped into openshift-test extension Image struct~~ OCPBUGS-61465: Add a new field Mapped into openshift-test extension Image struct Sep 17, 2025

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 17, 2025

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 17, 2025

bertinatto reviewed Sep 17, 2025

View reviewed changes

openshift-hack/cmd/k8s-tests-ext/k8s-tests.go Outdated Show resolved Hide resolved

dinhxuanvu force-pushed the mapped-image branch from feac727 to 370a1bf Compare September 17, 2025 17:05

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 17, 2025

openshift-ci bot requested a review from wangke19 September 17, 2025 17:06

bertinatto reviewed Sep 18, 2025

View reviewed changes

OCPBUGS-61465: Add a new field Mapped into openshift-test extension Image struct #2447

Are you sure you want to change the base?

OCPBUGS-61465: Add a new field Mapped into openshift-test extension Image struct #2447

Conversation

dinhxuanvu commented Sep 4, 2025

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Uh oh!

openshift-ci-robot commented Sep 4, 2025

Uh oh!

openshift-ci bot commented Sep 4, 2025

Uh oh!

dinhxuanvu commented Sep 4, 2025

Uh oh!

Uh oh!

openshift-ci-robot commented Sep 10, 2025

Uh oh!

dinhxuanvu commented Sep 10, 2025

Uh oh!

dinhxuanvu commented Sep 15, 2025

Uh oh!

bertinatto left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci-robot commented Sep 17, 2025

Uh oh!

dinhxuanvu commented Sep 17, 2025

Uh oh!

Uh oh!

openshift-ci-robot commented Sep 17, 2025

Uh oh!

openshift-ci-robot commented Sep 17, 2025

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Uh oh!

Uh oh!

openshift-ci-robot commented Sep 17, 2025

Uh oh!

dinhxuanvu commented Sep 17, 2025

Uh oh!

openshift-ci-robot commented Sep 17, 2025

Uh oh!

openshift-ci bot commented Sep 17, 2025

Uh oh!

bertinatto Sep 18, 2025

Choose a reason for hiding this comment

Uh oh!

dinhxuanvu Sep 18, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!