OCPBUGS-54175: Add /etc/docker/certs.d to template #4933

tmshort · 2025-03-20T19:29:24Z

OLMv1 uses containers/images/v5 which looks in the /etc/docker/certs.d directory for certificates used in image fetching. It is necessary for local registries as well as additional CAs specified in images.config.

- What I did
Added /etc/docker/certs.d to template

- How to verify it
Ensure /etc/docker/certs.d exists after cluster startup

- Description for the changelog
Add /etc/docker/certs.d to template

openshift-ci-robot · 2025-03-20T19:29:30Z

@tmshort: This pull request references Jira Issue OCPBUGS-52282, which is invalid:

expected the bug to target the "4.19.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

OLMv1 uses containers/images/v5 which looks in the /etc/docker/certs.d directory for certificates used in image fetching. It is necessary for local registries as well as additional CAs specified in images.config.

- What I did
Added /etc/docker/certs.d to template

- How to verify it
Ensure /etc/docker/certs.d exists after cluster startup

- Description for the changelog
Add /etc/docker/certs.d to template

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

tmshort · 2025-03-20T19:31:18Z

/jira refresh

openshift-ci-robot · 2025-03-20T19:31:27Z

@tmshort: This pull request references Jira Issue OCPBUGS-52282, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.19.0) matches configured target version for branch (4.19.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

rphillips · 2025-03-20T20:44:23Z

/lgtm

jianzhangbjz · 2025-03-21T03:05:03Z

Still get https://issues.redhat.com/browse/OCPBUGS-48795, details: https://issues.redhat.com/browse/OCPBUGS-52282
/hold

tmshort · 2025-03-24T14:04:46Z

Still get https://issues.redhat.com/browse/OCPBUGS-48795, details: https://issues.redhat.com/browse/OCPBUGS-52282

This is expected due to the runlevel difference between OLM and MCO.

tmshort · 2025-03-24T16:16:43Z

/retest-required

openshift-ci-robot · 2025-03-24T18:46:58Z

@tmshort: This pull request references Jira Issue OCPBUGS-54175, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.19.0) matches configured target version for branch (4.19.0)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

OLMv1 uses containers/images/v5 which looks in the /etc/docker/certs.d directory for certificates used in image fetching. It is necessary for local registries as well as additional CAs specified in images.config.

- What I did
Added /etc/docker/certs.d to template

- How to verify it
Ensure /etc/docker/certs.d exists after cluster startup

- Description for the changelog
Add /etc/docker/certs.d to template

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

tmshort · 2025-03-24T18:47:03Z

/jira refresh

openshift-ci-robot · 2025-03-24T18:47:07Z

@tmshort: This pull request references Jira Issue OCPBUGS-54175, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.19.0) matches configured target version for branch (4.19.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

tmshort · 2025-03-24T19:42:14Z

This can't be tested as part of OCPBUGS-52282, when it is backported to 4.18, it can then be tested with that bug.

jianzhangbjz · 2025-03-25T03:09:24Z

Test pass, details: https://issues.redhat.com/browse/OCPBUGS-54175
/unhold

tmshort · 2025-03-25T17:23:35Z

/retest-required

OLMv1 uses containers/images/v5 which looks in the /etc/docker/certs.d directory for certificates used in image fetching. It is necessary for local registries as well as additional CAs specified in images.config. Signed-off-by: Todd Short <[email protected]>

tmshort · 2025-03-28T18:02:42Z

@rphillips can I get another LGTM? I rebased.

openshift-ci · 2025-03-28T22:20:27Z

@tmshort: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-azure-ovn-upgrade-out-of-change	`2ed66e8`	link	false	`/test e2e-azure-ovn-upgrade-out-of-change`
ci/prow/e2e-gcp-op-ocl	`2ed66e8`	link	false	`/test e2e-gcp-op-ocl`
ci/prow/okd-scos-e2e-aws-ovn	`2ed66e8`	link	false	`/test okd-scos-e2e-aws-ovn`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

tmshort · 2025-04-07T14:15:53Z

ping @rphillips @dkhater-redhat @LorbusChris ?

djoshy · 2025-04-08T17:24:00Z

/lgtm

openshift-ci · 2025-04-08T17:24:23Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djoshy, rphillips, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [djoshy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2025-04-08T21:44:10Z

@tmshort: Jira Issue OCPBUGS-54175: All pull requests linked via external trackers have merged:

openshift/machine-config-operator#4933

Jira Issue OCPBUGS-54175 has been moved to the MODIFIED state.

In response to this:

OLMv1 uses containers/images/v5 which looks in the /etc/docker/certs.d directory for certificates used in image fetching. It is necessary for local registries as well as additional CAs specified in images.config.

- What I did
Added /etc/docker/certs.d to template

- How to verify it
Ensure /etc/docker/certs.d exists after cluster startup

- Description for the changelog
Add /etc/docker/certs.d to template

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-bot · 2025-04-09T01:10:37Z

[ART PR BUILD NOTIFIER]

Distgit: ose-machine-config-operator
This PR has been included in build ose-machine-config-operator-container-v4.19.0-202504090015.p0.gddc18e8.assembly.stream.el9.
All builds following this will include this PR.

tmshort · 2025-09-30T17:37:08Z

/cherry-pick release-4.18

openshift-cherrypick-robot · 2025-09-30T17:37:52Z

@tmshort: new pull request created: #5320

In response to this:

/cherry-pick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci bot requested review from LorbusChris and dkhater-redhat March 20, 2025 19:30

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 20, 2025

openshift-ci bot assigned rphillips Mar 20, 2025

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 20, 2025

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 21, 2025

tmshort changed the title ~~OCPBUGS-52282: Add /etc/docker/certs.d to template~~ OCPBUGS-54175: Add /etc/docker/certs.d to template Mar 24, 2025

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 25, 2025

tmshort force-pushed the etc-docker branch from 46d4f8a to 2ed66e8 Compare March 28, 2025 18:01

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 28, 2025

openshift-ci bot assigned djoshy Apr 8, 2025

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 8, 2025

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 8, 2025

openshift-merge-bot bot merged commit ddc18e8 into openshift:main Apr 8, 2025
14 of 17 checks passed

lwan-wanglin mentioned this pull request May 7, 2025

MULTIARCH-5405: use hostmount-anyuid-v2 SCC for ppc if cluster version >= 4.19 outrigger-project/multiarch-tuning-operator#604

Merged

tmshort deleted the etc-docker branch September 30, 2025 15:54

openshift-cherrypick-robot mentioned this pull request Sep 30, 2025

[release-4.18] OCPBUGS-62499: Add /etc/docker/certs.d to template #5320

Merged

lwan-wanglin mentioned this pull request Oct 16, 2025

[release-4.18] OCPBUGS-63119: SCC: add hostmount-anyuid-v2 openshift/cluster-kube-apiserver-operator#1937

Open

OCPBUGS-54175: Add /etc/docker/certs.d to template #4933

OCPBUGS-54175: Add /etc/docker/certs.d to template #4933

Conversation

tmshort commented Mar 20, 2025

Uh oh!

openshift-ci-robot commented Mar 20, 2025

Uh oh!

tmshort commented Mar 20, 2025

Uh oh!

openshift-ci-robot commented Mar 20, 2025

Uh oh!

rphillips commented Mar 20, 2025

Uh oh!

jianzhangbjz commented Mar 21, 2025

Uh oh!

tmshort commented Mar 24, 2025

Uh oh!

tmshort commented Mar 24, 2025

Uh oh!

openshift-ci-robot commented Mar 24, 2025

Uh oh!

tmshort commented Mar 24, 2025

Uh oh!

openshift-ci-robot commented Mar 24, 2025

Uh oh!

tmshort commented Mar 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jianzhangbjz commented Mar 25, 2025

Uh oh!

tmshort commented Mar 25, 2025

Uh oh!

tmshort commented Mar 28, 2025

Uh oh!

openshift-ci bot commented Mar 28, 2025

Uh oh!

tmshort commented Apr 7, 2025

Uh oh!

djoshy commented Apr 8, 2025

Uh oh!

openshift-ci bot commented Apr 8, 2025

Uh oh!

Uh oh!

openshift-ci-robot commented Apr 8, 2025

Uh oh!

openshift-bot commented Apr 9, 2025

Uh oh!

tmshort commented Sep 30, 2025

Uh oh!

openshift-cherrypick-robot commented Sep 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

tmshort commented Mar 24, 2025 •

edited

Loading