Skip to content

UCP: wireup slow connect-to-iface lanes on demand #10640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 26 commits into
base: master
Choose a base branch
from

Conversation

evgeny-leksikov
Copy link
Contributor

@evgeny-leksikov evgeny-leksikov commented Apr 17, 2025

What?

Establish slow & connect-to-iface lanes on demand

Why?

with growing scale of systems p2p connection may have multiple alternative connection paths, not all of them can be utilized (depends on real usage of protocols), so we can safe resources

How?

  • do not initialize slow and connect-to-iface lanes on first wireup round
  • per access of lane from data path protocols (ucp_ep_lane(lane_idx))
  • re-request address of remote side
  • connect the lane on address replay wireup msg

@evgeny-leksikov evgeny-leksikov force-pushed the ucp_wireup_ondemand_connect_to_iface2 branch from 926bcb5 to a210a31 Compare April 29, 2025 08:58
@evgeny-leksikov
Copy link
Contributor Author

@gleon99 @yosefe Could you pls take a look just from high level , if it's OK I'll polish it and break down on smaller PRs.

- Added a new parameter for comparison flags to the ucp_ep_config_is_equal function.
- Introduced flags for comparing lanes layout and performing a strong comparison.
…tor lane access functions

- Refactored lane access functions to separate raw lane retrieval from the common access method.
- Added new wireup message types: ADDR_REQUEST and ADDR_REPLY.
 - Refacored KA reply EP to be reused for ADDR_REPLY.
@gleon99
Copy link
Contributor

gleon99 commented May 13, 2025

@evgeny-leksikov in very high level, makes sense. let's split

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants