Skip to content

fix(ci): run update-samples in workflow #2037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AllieJonsson
Copy link
Contributor

Status

READY

Description

Build samples before testing them, to make sure we don't break samples in a PR

Copy link
Member

@soartec-lab soartec-lab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AllieJonsson
Thanks!
Shouldn't it be an error if a diff exists in the sample?

@soartec-lab soartec-lab self-assigned this Apr 17, 2025
@AllieJonsson
Copy link
Contributor Author

I'm not sure, what do you think?
Having that be an error means you always have to generate samples when creating a pull request, isn't it enough that the build will fail if the test in the following step fails?

@soartec-lab
Copy link
Member

@AllieJonsson
Ah, I've missed updating samples a few times in the past, so I thought that if I could check them all at once, I would be able to notice unintended changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants