Skip to content

Conversation

turegjorup
Copy link
Contributor

Link to ticket

https://leantime.itkdev.dk/dashboard/show?tab=ticketdetails#/tickets/showTicket/2773

Description

  • Nginx/http headers: Ensure "online-check" can be cached

Screenshot of the result

If your change affects the user interface you should include a screenshot of the result with the pull request.

Checklist

  • My code is covered by test cases.
  • My code passes our test (all our tests).
  • My code passes our static analysis suite.
  • My code passes our continuous integration process.

If your code does not pass all the requirements on the checklist you have to add a comment explaining why this change
should be exempt from the list.

Additional comments or questions

If you have any further comments or questions for the reviewer please add them here.

@turegjorup turegjorup requested a review from cableman October 28, 2024 22:12
@turegjorup turegjorup self-assigned this Oct 28, 2024
@turegjorup turegjorup requested a review from tuj October 28, 2024 22:14
try_files $uri $uri/ =404;
}

location = {{ getenv "APP_SCREEN_CLIENT_PATH" "" }}/online-check/ {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indented too much

@turegjorup turegjorup marked this pull request as draft October 30, 2024 08:54
@turegjorup
Copy link
Contributor Author

Redundant

@turegjorup turegjorup closed this Mar 31, 2025
@turegjorup turegjorup deleted the feature/2773_ensure_online_check_is_cached branch March 31, 2025 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants