Skip to content

2773: Ensure "online-check" can be cached #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

2773: Ensure "online-check" can be cached #141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
685148c
2773: Ensure "online-check" can be cached
turegjorup Oct 28, 2024
b9b8fa8
2773: Update Changelog
turegjorup Oct 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions .docker/vhost.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,14 @@ server {
proxy_pass http://node:3000;

add_header Cache-Control "no-store, no-cache, must-revalidate, proxy-revalidate, max-age=0";
add_header Pragma "no-cache";
add_header Expires "0";
}

location /client/online-check/ {
proxy_set_header X-Forwarded-For $remote_addr;
proxy_set_header Host $http_host;
proxy_pass http://node:3000;

add_header Cache-Control "public, max-age=604800";
}

location /client/ws {
Expand Down
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@ All notable changes to this project will be documented in this file.

## Unreleased

- [#141](https://github.com/os2display/display-client/pull/141)
- Avoided setting ER105 in url when no token exists in local storage.

## [2.1.1] - 2024-10-23

- [#138](https://github.com/os2display/display-client/pull/138)
Expand Down
6 changes: 4 additions & 2 deletions infrastructure/itkdev/etc/confd/templates/default.conf.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@ server {
root /var/www/html;

add_header Cache-Control "no-store, no-cache, must-revalidate, proxy-revalidate, max-age=0";
add_header Pragma "no-cache";
add_header Expires "0";

location {{ getenv "APP_SCREEN_CLIENT_PATH" "/" }} {
rewrite ^{{ getenv "APP_SCREEN_CLIENT_PATH" "/" }}(.*) /$1 break;
Expand All @@ -15,6 +13,10 @@ server {
try_files $uri $uri/ =404;
}

location = {{ getenv "APP_SCREEN_CLIENT_PATH" "" }}/online-check/ {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indented too much

add_header Cache-Control "public, max-age=604800";
}

location = {{ getenv "APP_SCREEN_CLIENT_PATH" "" }}/robots.txt {
add_header Content-Type text/plain;
add_header X-Robots-Tag "noindex, nofollow, nosnippet, noarchive";
Expand Down
4 changes: 4 additions & 0 deletions infrastructure/os2display/etc/confd/templates/default.conf.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,10 @@ server {
try_files $uri $uri/ =404;
}

location = {{ getenv "APP_SCREEN_CLIENT_PATH" "" }}/online-check/ {
add_header Cache-Control "public, max-age=604800";
}

location = {{ getenv "APP_SCREEN_CLIENT_PATH" "" }}/robots.txt {
add_header Content-Type text/plain;
add_header X-Robots-Tag "noindex, nofollow, nosnippet, noarchive";
Expand Down
Loading