release 10.16.0

[DeepDiver1975]

Description

Release 10.16.0

Motivation and Context

🍻

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Database schema changes (next release will require increase of minor version instead of patch)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests only (no source changes)

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:
• Changelog item, see TEMPLATE

[update-docs]

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

[phil-davis]

https://drone.owncloud.com/owncloud/core/40325/21/6

The drone pipeline that tests against an oC10 system backed by storage on Windows Server is timing out.
The same error as is happening in PR #41408

Who is looking after that these days?

[phil-davis]

https://drone.owncloud.com/owncloud/core/40329/21/6

PHPUnit 9.6.25 by Sebastian Bergmann and contributors.

Runtime:       PHPDBG 7.4.33
Configuration: phpunit-autotest-external.xml
................................................................. 65 / 90 ( 72%)
.........................                                         90 / 90 (100%)

Time: 00:00.919, Memory: 50.00 MB

OK (90 tests, 212 assertions)

The ordinary files_external PHP unit tests are passing. And the install and startup of the system-under-test seemed to work.

But when running the specific SMB storage tests, they all fail because they can't even create a root dir to get started:

phpdbg -d memory_limit=6G -rr ../lib/composer/bin/phpunit --configuration phpunit-autotest-external.xml --coverage-clover output/coverage/autotest-external-clover-sqlite-windows.xml ../apps/files_external/tests/Storage/SmbTest.php
[Welcome to phpdbg, the interactive PHP debugger, v7.4.33]
To get help using phpdbg type "help" and press enter
[Please report bugs to <http://bugs.php.net/report.php>]
PHPUnit 9.6.25 by Sebastian Bergmann and contributors.

Runtime:       PHPDBG 7.4.33
Configuration: phpunit-autotest-external.xml

FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF 65 / 85 ( 76%)
FFFFFFFFFFFFFFFFFFFF                                              85 / 85 (100%)

Time: 00:10.130, Memory: 40.00 MB

There were 85 failures:

1) OCA\Files_External\Tests\Storage\SmbTest::testRenameWithSpaces
Failed to create a root dir
Failed asserting that false is true.

/drone/src/apps/files_external/tests/Storage/SmbTest.php:52
phpvfscomposer:///drone/src/lib/composer/phpunit/phpunit/phpunit:106
...

I suppose that the SMB server is up, but it does not have the SMB share available with the usual credentials.

[phil-davis]

https://drone.owncloud.com/owncloud/core/40334/26/8
All tests passed.
But the Sonar Analysis failed:

INFO: Deploy location /opt/sonar-scanner/.sonar/js/node-runtime, tagetRuntime: /opt/sonar-scanner/.sonar/js/node-runtime/node,  version: /opt/sonar-scanner/.sonar/js/node-runtime/version.txt
ERROR: Error relocating /opt/sonar-scanner/.sonar/js/node-runtime/node: _ZNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEE15_M_replace_coldEPcmPKcmm: symbol not found
WARN: Embedded Node.js failed to deploy in /root/.sonar.
You can change the location by setting the option `sonar.userHome` or the environment variable `SONAR_USER_HOME`.
Otherwise, it will default to /opt/sonar-scanner/.sonar/js/node-runtime.
Will fallback to host Node.js.
org.sonar.plugins.javascript.nodejs.NodeCommandException: Failed to determine the version of Node.js, exit value 127. Executed: '/opt/sonar-scanner/.sonar/js/node-runtime/node -v'

Do we still have Sonar Analysis set up with SonarCloud?
Do we still want to do this sonar-analysis step?
(I notice that there is some CodeQL analysis happening separately)

[DeepDiver1975]

@phil-davis I have no clue - let's just drop sonar - who is looking into it ....

Can you please take care? Thank you