Skip to content

Conversation

@ethifus
Copy link

@ethifus ethifus commented Jan 19, 2016

This pull request introduces Python 3.4 compatibility. It was tested with Python 3.4.3 and Python 2.7.10. I hope it could serve as a base for better Python 3.x support.

@ethifus ethifus mentioned this pull request Jan 19, 2016
@PVince81
Copy link
Contributor

@cosenal mind helping review this ?

@ethifus looks like this breaks CI: https://travis-ci.org/owncloud/pyocclient/jobs/103321288
Does this require additional python packages to be installed upfront ?
You might want to edit .travis.yml https://github.com/owncloud/pyocclient/blob/master/.travis.yml#L13 to add them, if needed.

@ethifus
Copy link
Author

ethifus commented Jan 19, 2016

@PVince81 you are right I forgot to add six module to .travis.yml.

@cosenal
Copy link
Member

cosenal commented Jan 19, 2016

sure, I'll review tonight
On Jan 19, 2016 1:59 PM, "ethifus" [email protected] wrote:

@PVince81 https://github.com/PVince81 you right I forgot to add six
module to .travis.yml.


Reply to this email directly or view it on GitHub
#146 (comment).

@PVince81 PVince81 added this to the 0.3 milestone Mar 17, 2016
@PVince81
Copy link
Contributor

PVince81 commented Jul 8, 2016

@ethifus can you rebase ? The travis tests now run on docker.

Then you can enable Python3 tests by editing .travis.yml.

@blizzz blizzz mentioned this pull request Jul 27, 2016
@PVince81 PVince81 merged commit 57a5ba6 into owncloud:master Aug 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants