Skip to content

Conversation

JP-Ellis
Copy link
Contributor

Update all the dependencies in one go, to help get through the backlog.

Other than the upgrades, the only notable change is removing the airbnb eslint configs as they do not support ESLint 9.

@JP-Ellis JP-Ellis self-assigned this Jun 11, 2025
@JP-Ellis JP-Ellis force-pushed the chore/update-everything branch from 2e8e851 to 60f533b Compare June 11, 2025 00:26
@mefellows mefellows force-pushed the chore/update-everything branch 5 times, most recently from 0d36954 to 96cd9f6 Compare July 27, 2025 13:19
@YOU54F YOU54F force-pushed the chore/update-everything branch from 96cd9f6 to 7816e94 Compare August 22, 2025 14:13
@YOU54F
Copy link
Member

YOU54F commented Aug 22, 2025

the upgrade of eslint excludes node 16, which is eol anyway, we can bump but would need to be a breaking change and note in the engines section of the package.json

rimraf looks like it has an issue on windows

mocha looks it like has an issue with node 18, this went eol 3 months ago, so we could lock the node engines to 20.

It seems a shame as these are test dependencies and having pact-js more compatible with older applications would be preferable for me or needing to run the latest great dev deps, especially when we rarely rely on new features, so it would only be bug fixes, and as pact-js-core is used as a testing tool and we wouldn't expect it to be used in production, I am less worried

hmmm 🤔

@JP-Ellis
Copy link
Contributor Author

Thanks for taking a look! Sorry I started trying to fix this but didn't see it through.

@YOU54F
Copy link
Member

YOU54F commented Aug 25, 2025

Thanks for taking a look! Sorry I started trying to fix this but didn't see it through.

no need to apologise at all buddy!

sometimes when I’m hoovering up, i get distracted and start cleaning something else 😅

@YOU54F
Copy link
Member

YOU54F commented Sep 3, 2025

prev process for locking to node engines

#454

major bump

@YOU54F YOU54F force-pushed the chore/update-everything branch from 7816e94 to 95aa57d Compare September 15, 2025 15:51
@YOU54F YOU54F force-pushed the chore/update-everything branch from 82d0f9d to 6e512a8 Compare September 15, 2025 16:23
@YOU54F
Copy link
Member

YOU54F commented Sep 15, 2025

Right

  • node engines locked to 20 or greater
  • node 24 npm publish --dry-run fails if it tries to publish over an existing version. Previous versions didn't. We don't bump version prior to running tests, so this is an issue for us when creating local prebuilds or in ci
  • rimraf removed globbing pattern support as a default option and requires opt-in with --glob
  • published a version prior to release with latest ffi, which will support versions of node less than 20

@YOU54F YOU54F self-requested a review September 15, 2025 16:46
Copy link
Member

@YOU54F YOU54F left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No yaks were harmed, but several were shaved in this PR.

nice work

@YOU54F YOU54F changed the title chore(deps): update everything chore(deps): update everything - BREAKING CHANGE (node >=20) Sep 15, 2025
@YOU54F YOU54F merged commit 10b7014 into master Sep 15, 2025
30 checks passed
@YOU54F YOU54F deleted the chore/update-everything branch September 15, 2025 16:48
@JP-Ellis
Copy link
Contributor Author

Thank you @YOU54F for all the work getting this over the line!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants