Add bidirectional contracts state migration #390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkhry
reviewed
Nov 17, 2025
| } | ||
|
|
||
| /// Applies REVM storage diffs to pallet-revive (REVM → pallet-revive sync) | ||
| /// Note: Balance/nonce are NOT synced here as they're handled by migration in select_revive() |
There was a problem hiding this comment.
i'm a bit confused as to why not migrate Balance and Nonce anyways?
Collaborator
Author
There was a problem hiding this comment.
We need to sync it in vm.pvm(true/false) anyway, since it may be modified using cheatcodes. If we want to drop syncing when switching VMs, we also need to sync cheatcode execution between VMs, what we do not do it currently.
filip-parity
approved these changes
Nov 18, 2025
pkhry
approved these changes
Nov 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #263