forked from foundry-rs/foundry
-
Notifications
You must be signed in to change notification settings - Fork 7
Add bidirectional contracts state migration #390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
219ba5c
Add immutables migration
smiasojed 015dfe2
Cleanup
smiasojed ebd649a
Clippy
smiasojed 54c2a24
Merge branch 'master' into sm/migration
smiasojed 37a8381
Updated logs
smiasojed a66a178
Add support for calling test contract from pallet-revive
smiasojed 09e8abe
Cleanup
smiasojed 39a7aff
Add bidirectional contracts state migration
smiasojed 0edfd0a
Merge remote-tracking branch 'origin/master' into sm/state-migration
smiasojed 758d200
refactoring
smiasojed 243f430
Merge remote-tracking branch 'origin/master' into sm/state-migration
smiasojed 5771c52
Refactoring
smiasojed d80590e
Fix comments
smiasojed ca8bad7
Clippy
smiasojed File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm a bit confused as to why not migrate Balance and Nonce anyways?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to sync it in vm.pvm(true/false) anyway, since it may be modified using cheatcodes. If we want to drop syncing when switching VMs, we also need to sync cheatcode execution between VMs, what we do not do it currently.