PMM-7 Refresh connection section #1711
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BupycHuk
requested review from
YashSartanpara1,
Copilot and
matejkubinec
and removed request for
YashSartanpara1
There was a problem hiding this comment.
Pull Request Overview
This PR updates the refresh rate configuration for several template variables in the PostgreSQL Instance Summary dashboard. The change increases the refresh interval from 1 to 2, which affects how frequently these variables are re-evaluated.
- Changes refresh rate from 1 to 2 for multiple dashboard template variables
- Targets variables related to uptime, connection counts, and active connections
- Aims to improve dashboard performance by reducing query frequency
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| "refId": "StandardVariableQuery" | ||
| }, | ||
| "refresh": 1, | ||
| "refresh": 2, |
There was a problem hiding this comment.
The refresh value change from 1 to 2 lacks documentation about what these numeric values represent (seconds, refresh cycles, etc.) and the rationale for this specific change. Consider adding comments to clarify the refresh interval meaning and performance impact.
Suggested change
| "refresh": 2, | |
| "refresh": 2, | |
| "__comment": "The 'refresh' value controls when the variable is updated: 1=on dashboard load, 2=on time range change. Here, 2 ensures the 'uptime' variable is refreshed when the time range changes, which is important for accurate reporting. See Grafana docs: https://grafana.com/docs/grafana/latest/variables/variable-types/add-query-variable/#refresh-options", |
Member
|
@YashSartanpara1 PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'refresh' value controls when the variable is updated: 1=on dashboard load, 2=on time range change. Here, 2 ensures the uptime, connection counts, and active connections variables are refreshed when the time range changes, which is important for accurate reporting. See Grafana docs: https://grafana.com/docs/grafana/latest/variables/variable-types/add-query-variable/#refresh-options
Fixes percona/pmm#4357