Skip to content

PMM-7 Refresh connection section #1711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BupycHuk wants to merge 1 commit into
base: main
Choose a base branch
from
Open

PMM-7 Refresh connection section #1711

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions dashboards/PostgreSQL/PostgreSQL_Instance_Summary.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5057,7 +5057,7 @@
"query": "query_result(pg_postmaster_uptime_seconds{service_name=~\"$service_name\"}/60/60/24)",
"refId": "StandardVariableQuery"
},
"refresh": 1,
"refresh": 2,
Copy link

Copilot AI Aug 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The refresh value change from 1 to 2 lacks documentation about what these numeric values represent (seconds, refresh cycles, etc.) and the rationale for this specific change. Consider adding comments to clarify the refresh interval meaning and performance impact.

Suggested change
"refresh": 2,
"refresh": 2,
"__comment": "The 'refresh' value controls when the variable is updated: 1=on dashboard load, 2=on time range change. Here, 2 ensures the 'uptime' variable is refreshed when the time range changes, which is important for accurate reporting. See Grafana docs: https://grafana.com/docs/grafana/latest/variables/variable-types/add-query-variable/#refresh-options",

Copilot uses AI. Check for mistakes.
"regex": "/.* ([^\\ ]*) .*/",
"type": "query"
},
Expand Down Expand Up @@ -5152,7 +5152,7 @@
"query": "query_result(sum(pg_stat_activity_count{service_name=\"$service_name\"}))",
"refId": "StandardVariableQuery"
},
"refresh": 1,
"refresh": 2,
"regex": "/.* ([^\\ ]*) .*/",
"type": "query"
},
Expand All @@ -5170,7 +5170,7 @@
"query": "query_result(sum(pg_stat_activity_count{service_name=\"$service_name\",state=\"active\"}))",
"refId": "StandardVariableQuery"
},
"refresh": 1,
"refresh": 2,
"regex": "/.* ([^\\ ]*) .*/",
"type": "query"
},
Expand Down Expand Up @@ -5209,7 +5209,7 @@
"name": "uptimedecimal",
"options": [],
"query": "select round($uptime, 2)",
"refresh": 1,
"refresh": 2,
"regex": "",
"type": "query"
},
Expand Down
Loading