PSMDB-1078: fix failing tests in storage_inmemory_kv_engine_test #1592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... otherwise all tests which rely on timestamps will fail because the table logging will be enabled - see WiredTigerUtil::useTableLogging.
There was a problem hiding this comment.
Pull Request Overview
This PR updates the KVEngine test harness to handle ephemeral storage engines (e.g., in-memory WiredTiger) differently when testing last stable recovery timestamps. The changes address a behavioral difference where ephemeral engines set the last stable timestamp immediately upon calling setStableTimestamp(), while persistent engines only update it after a checkpoint.
Key changes:
- Added conditional logic in test assertions to handle ephemeral vs. persistent storage engine behavior
- Refactored in-memory test harness to properly initialize StorageEngine via StorageEngineImpl
- Simplified test setup by replacing global settings calls with explicit local variables
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/mongo/db/storage/kv/kv_engine_test_harness.cpp | Updated two tests to conditionally assert different behavior for ephemeral engines when checking last stable recovery timestamp |
| src/mongo/db/storage/inmemory/inmemory_kv_engine_test.cpp | Refactored test harness helper to initialize engine via StorageEngineImpl and use explicit replica set configuration instead of global settings |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…test If the StorageEngineImpl is not created some of the tests fail due to missing the _mdb_catalog which is created in the StorageEngineImpl constructor.
Update RollingBackToLastStable and CommitBehindStable test cases to handle ephemeral storage engine behavior where the last stable recovery timestamp is set immediately when setStableTimestamp is called, unlike non ephemeral storage engine that require a checkpoint to advance the timestamp.
plebioda
force-pushed
the
PSMDB-1078-fix-inmemory_kv_engine_test-master
branch
from
0ce8049 to
688c452
Compare
plebioda
commented
Oct 30, 2025
igorsol
requested changes
Oct 30, 2025
igorsol
approved these changes
Nov 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.