PSMDB-1078: fix failing tests in storage_inmemory_kv_engine_test (v8.0) #1593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... otherwise all tests which rely on timestamps will fail because the table logging will be enabled - see WiredTigerUtil::useTableLogging.
…test If the StorageEngineImpl is not created some of the tests fail due to missing the _mdb_catalog which is created in the StorageEngineImpl constructor.
Update RollingBackToLastStable and CommitBehindStable test cases to handle ephemeral storage engine behavior where the last stable recovery timestamp is set immediately when setStableTimestamp is called, unlike non ephemeral storage engine that require a checkpoint to advance the timestamp.
There was a problem hiding this comment.
Pull Request Overview
This PR updates the in-memory storage engine test harness to properly wrap the KVEngine in a StorageEngineImpl and adapts related tests to handle ephemeral storage engine behavior differences.
- Wraps WiredTiger in-memory KVEngine in StorageEngineImpl for proper test setup
- Adds conditional checks for ephemeral engines in timestamp-related tests
- Implements retry logic for handling ObjectIsBusy errors during ident drops
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/mongo/db/storage/kv/kv_engine_test_harness.cpp | Adds retry loop for ObjectIsBusy errors and conditional assertions for ephemeral engine timestamp behavior |
| src/mongo/db/storage/inmemory/inmemory_kv_engine_test.cpp | Refactors test harness to wrap KVEngine in StorageEngineImpl with replica set configuration |
| src/mongo/db/storage/inmemory/SConscript | Adds storage_engine_impl dependency for the test build |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…y from dropIdent The TemporaryRecordStoreSimple test can fail when dropIdent() returns ErrorCodes::ObjectIsBusy, which occurs when the ident is temporarily in use. This is a transient condition that should be retried. This change adds retry logic to the test, retrying dropIdent() until it succeeds when ObjectIsBusy is returned. This matches the pattern used in production code (e.g. WiredTigerKVEngine::dropIdentForImport).
plebioda
force-pushed
the
PSMDB-1078-fix-inmemory_kv_engine_test-master-v8.0
branch
from
ae79b7d to
875d657
Compare
plebioda
commented
Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.