Skip to content

Return masternodes networks addresses in RPC - #18

Open
Safranil wants to merge 2 commits into
phoenixkonsole:2.1.0.0from
Safranil:master
Open

Return masternodes networks addresses in RPC#18
Safranil wants to merge 2 commits into
phoenixkonsole:2.1.0.0from
Safranil:master

Conversation

@Safranil

Copy link
Copy Markdown

Hi,

I need to get all masternodes network address from the JSON-RPC API for a project about the Transcendence blockchain. So I changed the RPC to add this functionality.

Hope this can be added officially.

@phoenixkonsole

Copy link
Copy Markdown
Owner

Thanks we will give it a try. On your end it did work? Can you tell us something about the project you are working on ?

@Safranil

Safranil commented Dec 1, 2019

Copy link
Copy Markdown
Author

Thanks we will give it a try. On your end it did work?

Yes, it worked, you just need to pass an empty filter listmasternodes "" true.

Can you tell us something about the project you are working on ?

I'm coding a website to collect and display data about the blockchain and it's network, the functionality I want to implements are:

  • A map of masternodes (per tier)
  • An explorer (like Iquidus) with some advanced tools
  • Statistics from exchanges (if I can get data from them)
  • A masternode tester (open port, block height, last blocks comparison, wallet & protocol version)
  • ...

@akshaynexus

Copy link
Copy Markdown
Contributor

try using 2.1.0.0 and pr it there,cause i already added total teir in getmasternodecount rpc

@akshaynexus

Copy link
Copy Markdown
Contributor

nvm just saw it,lgtm

Comment thread src/rpcmasternode.cpp

"\nArguments:\n"
"1. \"filter\" (string, optional) Filter search text. Partial match by txhash, status, or addr.\n"
"2. network (boolean, optional, default=false) Return the network address of masternodes.\n"

@akshaynexus akshaynexus Dec 8, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add \"filter\" type text there,and should be good

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand what you want, can you explain your comment?

@Safranil
Safranil requested a review from akshaynexus April 26, 2020 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants