Skip to content

Return masternodes networks addresses in RPC #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Safranil wants to merge 2 commits into
base: 2.1.0.0
Choose a base branch
from
Open

Return masternodes networks addresses in RPC #18

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7870406
Return masternodes networks addresses
Safranil Nov 28, 2019
d230acb
Add network arg on command help for listmasternode
Safranil Dec 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/rpcmasternode.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,16 +240,19 @@ Value masternode(const Array& params, bool fHelp)
Value listmasternodes(const Array& params, bool fHelp)
{
std::string strFilter = "";
bool returnNetworkAddress = false;

if (params.size() == 1) strFilter = params[0].get_str();
if (params.size() >= 1) strFilter = params[0].get_str();
if (params.size() == 2) returnNetworkAddress = (params[1].get_str() == "true" ? true : false);

if (fHelp || (params.size() > 1))
if (fHelp || (params.size() > 2))
throw runtime_error(
"listmasternodes ( \"filter\" )\n"
"listmasternodes ( \"filter\" network )\n"
"\nGet a ranked list of masternodes\n"

"\nArguments:\n"
"1. \"filter\" (string, optional) Filter search text. Partial match by txhash, status, or addr.\n"
"2. network (boolean, optional, default=false) Return the network address of masternodes.\n"

@akshaynexus akshaynexus Dec 8, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add \"filter\" type text there,and should be good

@Safranil Safranil Dec 29, 2019

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand what you want, can you explain your comment?


"\nResult:\n"
"[\n"
Expand Down Expand Up @@ -302,6 +305,7 @@ Value listmasternodes(const Array& params, bool fHelp)

obj.push_back(Pair("rank", (strStatus == "ENABLED" ? s.first : 0)));
obj.push_back(Pair("network", strNetwork));
if (returnNetworkAddress) obj.push_back(Pair("networkaddr", mn->addr.ToString()));
obj.push_back(Pair("txhash", strTxHash));
obj.push_back(Pair("outidx", (uint64_t)oIdx));
obj.push_back(Pair("tier", (uint64_t)mn->tier));
Expand Down