Improve SOAP constructor docs #4930
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since examples are numbered, and we don't want that here. Since informalexample doesn't accept a title, moped it to a comment to keep the context.
Contributor
Author
|
@nielsdos I do. |
Now that the acronym was merged in doc-base.
Contributor
Author
|
@nielsdos Now that the doc-base was merged with the WSDL acronym, I was able to address the last comment. Please merge if it's good. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although the vast majority of an old PR #537 was merged, the suggestions were not addressed. Per the original author's request, I'm addressing these suggestions in this new PR.