Rewrite SoapClient constructor documentation #537
Conversation
IMSoP
force-pushed
the
soapclient-constructor-rewrite
branch
from
8d3e513 to
8d1db39
Compare
IMSoP
force-pushed
the
soapclient-constructor-rewrite
branch
from
28b193c to
cf4092e
Compare
IMSoP
force-pushed
the
soapclient-constructor-rewrite
branch
from
cf4092e to
9845255
Compare
This constructor takes a large number of options, most of which were effectively undocumented, leading to a very high volume of User Notes. Some examples and caveats from these notes have been incorporated. The descriptions here are largely based on reverse-engineering the source code (which isn't particularly well commented) and experimenting locally, so may not be 100% accurate, or capture differences between versions.
IMSoP
force-pushed
the
soapclient-constructor-rewrite
branch
from
8791d10 to
8a29bad
Compare
IMSoP
changed the title
cmb69
left a comment
cmb69
left a comment
There was a problem hiding this comment.
Thank you for the PR! I very welcome improvement.
|
@IMSoP Pinging author |
@IMSoP Might you have the time to raise the new PR? |
|
@IMSoP There has been no update in several years. Is there still an interest in completing this PR? There are also some merge conflicts to resolve. |
|
@afilina Basically everything in this PR will be a merge conflict, because it was accidentally merged offline. So everything in this diff is actually live in the PHP manual, and has been for several years. In the meantime, as you've probably guessed, I'd completely forgotten about this. Having changed PCs, I don't currently have a dev environment set up to test some of the riskier markup changes, and life keeps happening, so I doubt I'll get back to it any time soon. Effectively, this is now more of a bug report from Christoph, pointing out the things I should have done at the time. If you're interested and have the time, feel free to create a new branch and "fix" those issues / suggestions. |
Needed to address this: php/doc-en#537
|
Closing in favor of a new PR which addresses the suggestions: #4930 |
4 participants
This constructor takes a large number of options, most of which
were effectively undocumented, leading to a very high volume of
User Notes. Some examples and caveats from these notes have been
incorporated.
The descriptions here are largely based on reverse-engineering
the source code (which isn't particularly well commented) and
experimenting locally, so may not be 100% accurate, or capture
differences between versions.