Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the plugin SDK to set common fields and configs in a single method #5623

Merged
merged 2 commits into from
Mar 5, 2025

Conversation

Warashi
Copy link
Contributor

@Warashi Warashi commented Mar 5, 2025

What this PR does:

  • merge setCommonFields and setConfig as setFields
  • parse DeployTargets in setFields method and store it as a DeploymentPluginServiceServer.deployTargets

Why we need it:

  • I don't want to make/call multiple methods to initialize gRPC server
  • resolve TODO: cache the unmarshaled config to avoid unmarshaling it multiple times.

Which issue(s) this PR fixes:

Part of #5530

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Copy link

codecov bot commented Mar 5, 2025

Codecov Report

Attention: Patch coverage is 0% with 32 lines in your changes missing coverage. Please review.

Project coverage is 26.54%. Comparing base (a64d83d) to head (f2e1ff1).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pkg/plugin/sdk/deployment.go 0.00% 29 Missing ⚠️
pkg/plugin/sdk/sdk.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5623      +/-   ##
==========================================
- Coverage   26.54%   26.54%   -0.01%     
==========================================
  Files         477      477              
  Lines       50663    50666       +3     
==========================================
  Hits        13450    13450              
- Misses      36150    36153       +3     
  Partials     1063     1063              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Warashi Warashi marked this pull request as ready for review March 5, 2025 02:52
t-kikuc
t-kikuc previously approved these changes Mar 5, 2025
Copy link
Member

@t-kikuc t-kikuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…y-target-prepare

Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
@Warashi
Copy link
Contributor Author

Warashi commented Mar 5, 2025

@t-kikuc I merged origin/master. Please re-approve 🙏🏻

Copy link
Member

@t-kikuc t-kikuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@t-kikuc t-kikuc enabled auto-merge (squash) March 5, 2025 08:12
Copy link
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@t-kikuc t-kikuc merged commit a252de8 into master Mar 5, 2025
14 of 18 checks passed
@t-kikuc t-kikuc deleted the deploy-target-prepare branch March 5, 2025 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants