Refactor the plugin SDK to set common fields and configs in a single method

pkg/plugin/sdk/deployment.go

@@ -40,8 +40,8 @@
 		Plugin
 
 		Register(server *grpc.Server)
-		setCommonFields(commonFields)
-		setConfig([]byte) error
+		// setFields sets the common fields and configs to the server.
+		setFields(commonFields) error
 		deployment.DeploymentServiceServer
 	}
 )
@@ -123,8 +123,9 @@
 	deployment.UnimplementedDeploymentServiceServer
 	commonFields
 
-	base   DeploymentPlugin[Config, DeployTargetConfig]
-	config Config
+	base          DeploymentPlugin[Config, DeployTargetConfig]
+	config        Config
+	deployTargets map[string]*DeployTarget[DeployTargetConfig]
 }
 
 // Name returns the name of the plugin.
@@ -141,17 +142,32 @@
 	deployment.RegisterDeploymentServiceServer(server, s)
 }
 
-func (s *DeploymentPluginServiceServer[Config, DeployTargetConfig]) setCommonFields(fields commonFields) {
+// setFields sets the common fields and configs to the server.
+func (s *DeploymentPluginServiceServer[Config, DeployTargetConfig]) setFields(fields commonFields) error {
 	s.commonFields = fields
-}
 
-func (s *DeploymentPluginServiceServer[Config, DeployTargetConfig]) setConfig(bytes []byte) error {
-	if bytes == nil {
-		return nil
+	cfg := fields.config
+	if cfg.Config != nil {
+		if err := json.Unmarshal(cfg.Config, &s.config); err != nil {
+			s.logger.Fatal("failed to unmarshal the plugin config", zap.Error(err))
+			return err
+		}
 	}
-	if err := json.Unmarshal(bytes, &s.config); err != nil {
-		return fmt.Errorf("failed to unmarshal the plugin config: %v", err)
+
+	s.deployTargets = make(map[string]*DeployTarget[DeployTargetConfig], len(cfg.DeployTargets))
+	for _, dt := range cfg.DeployTargets {
+		var sdkDt DeployTargetConfig
+		if err := json.Unmarshal(dt.Config, &sdkDt); err != nil {
+			s.logger.Fatal("failed to unmarshal deploy target config", zap.Error(err))
+			return err
+		}
+		s.deployTargets[dt.Name] = &DeployTarget[DeployTargetConfig]{
+			Name:   dt.Name,
+			Labels: dt.Labels,
+			Config: sdkDt,
+		}
 	}
+
 	return nil
 }
 
@@ -214,22 +230,12 @@
 	dtNames := request.GetInput().GetDeployment().GetDeployTargets(s.commonFields.config.Name)
 	deployTargets := make([]*DeployTarget[DeployTargetConfig], 0, len(dtNames))
 	for _, name := range dtNames {
-		dt := s.commonFields.config.FindDeployTarget(name)
-		if dt == nil {
+		dt, ok := s.deployTargets[name]
+		if !ok {
 			return nil, status.Errorf(codes.Internal, "the deploy target %s is not found in the piped plugin config", name)
 		}
 
-		// TODO: cache the unmarshaled config to avoid unmarshaling it multiple times.
-		var sdkDt DeployTargetConfig
-		if err := json.Unmarshal(dt.Config, &sdkDt); err != nil {
-			return nil, status.Errorf(codes.Internal, "failed to unmarshal deploy target config: %v", err)
-		}
-
-		deployTargets = append(deployTargets, &DeployTarget[DeployTargetConfig]{
-			Name:   name,
-			Labels: dt.Labels,
-			Config: sdkDt,
-		})
+		deployTargets = append(deployTargets, dt)
 	}
 
 	return executeStage(ctx, s.base, &s.config, deployTargets, client, request, s.logger)
@@ -259,17 +265,18 @@
 	deployment.RegisterDeploymentServiceServer(server, s)
 }
 
-func (s *StagePluginServiceServer[Config, DeployTargetConfig]) setCommonFields(fields commonFields) {
+// setFields sets the common fields and configs to the server.
+func (s *StagePluginServiceServer[Config, DeployTargetConfig]) setFields(fields commonFields) error {
 	s.commonFields = fields
-}
 
-func (s *StagePluginServiceServer[Config, DeployTargetConfig]) setConfig(bytes []byte) error {
-	if bytes == nil {
-		return nil
-	}
-	if err := json.Unmarshal(bytes, &s.config); err != nil {
-		return fmt.Errorf("failed to unmarshal the plugin config: %v", err)
+	cfg := fields.config
+	if cfg.Config != nil {
+		if err := json.Unmarshal(cfg.Config, &s.config); err != nil {
+			s.logger.Fatal("failed to unmarshal the plugin config", zap.Error(err))
+			return err
+		}
 	}
+
 	return nil
 }
 

pkg/plugin/sdk/sdk.go

@@ -157,15 +157,14 @@
 
 	// Start a gRPC server for handling external API requests.
 	{
-		deploymentServiceServer.setCommonFields(commonFields{
+		if err := deploymentServiceServer.setFields(commonFields{
 			config:       cfg,
 			logger:       input.Logger.Named("deployment-service"),
 			logPersister: persister,
 			client:       pipedapiClient,
 			toolRegistry: toolregistry.NewToolRegistry(pipedapiClient),
-		})
-		if err := deploymentServiceServer.setConfig(cfg.Config); err != nil {
-			input.Logger.Error("failed to set configuration", zap.Error(err))
+		}); err != nil {
+			input.Logger.Error("failed to set fields", zap.Error(err))
 			return err
 		}
 		var (