-
Notifications
You must be signed in to change notification settings - Fork 152
pkp/pkp-lib#10404 Allow arbitrary nesting depth in categories #1949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
c75447e
pkp/pkp-lib#10404 Allow arbitrary nesting depth in categories
taslangraham 14a2abc
updates based of review
taslangraham cf60b58
circular reference check
taslangraham 6024eb0
Apply suggestions from code review
taslangraham 72bdc03
Submodule update
taslangraham File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
<?php | ||
|
||
/** | ||
* @defgroup api_v1_categories Categories API requests | ||
*/ | ||
|
||
/** | ||
* @file api/v1/categories/index.php | ||
* | ||
* Copyright (c) 2025 Simon Fraser University | ||
* Copyright (c) 2025 John Willinsky | ||
* Distributed under the GNU GPL v3. For full terms see the file docs/COPYING. | ||
* | ||
* @ingroup api_v1_categories | ||
* | ||
* @brief Handle API requests for categories. | ||
*/ | ||
|
||
return new \PKP\handler\APIHandler(new \PKP\API\v1\categories\CategoryCategoryController()); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 changes: 33 additions & 0 deletions
33
classes/migration/upgrade/v3_6_0/I10404_UpdateCategoryImageNameFields.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
<?php | ||
|
||
/** | ||
* @file classes/migration/upgrade/v3_6_0/I10404_UpdateCategoryImageNameFields.php | ||
* | ||
* Copyright (c) 2025 Simon Fraser University | ||
* Copyright (c) 2025 John Willinsky | ||
* Distributed under the GNU GPL v3. For full terms see the file docs/COPYING. | ||
* | ||
* @class I10404_UpdateCategoryImageNameFields | ||
* | ||
* @brief Migration to update Category image data properties for compatibility with FieldUploadImage component | ||
*/ | ||
|
||
namespace APP\migration\upgrade\v3_6_0; | ||
|
||
class I10404_UpdateCategoryImageNameFields extends \PKP\migration\upgrade\v3_6_0\I10404_UpdateCategoryImageNameFields | ||
{ | ||
public function getContextFolderName(): string | ||
{ | ||
return 'presses'; | ||
} | ||
|
||
protected function getContextTable(): string | ||
{ | ||
return 'presses'; | ||
} | ||
|
||
protected function getContextIdColumn(): string | ||
{ | ||
return 'press_id'; | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule pkp
updated
31 files
Submodule ui-library
updated
15 files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -45,8 +45,7 @@ | |
{load_url_in_div id="seriesGridContainer" url=$seriesGridUrl} | ||
</tab> | ||
<tab id="categories" label="{translate key="grid.category.categories"}"> | ||
{capture assign=categoriesUrl}{url router=PKP\core\PKPApplication::ROUTE_COMPONENT component="grid.settings.category.CategoryCategoryGridHandler" op="fetchGrid" escape=false}{/capture} | ||
{load_url_in_div id="categoriesContainer" url=$categoriesUrl} | ||
<category-manager v-bind="pageInitConfig"></category-manager> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same question on |
||
</tab> | ||
</tabs> | ||
{/block} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.