-
Notifications
You must be signed in to change notification settings - Fork 152
pkp/pkp-lib#10404 Allow arbitrary nesting depth in categories #1949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
2c4d139
to
d4b0b44
Compare
ewhanson
approved these changes
Apr 16, 2025
cbf41f0
to
4252301
Compare
f04a9bc
to
2cee3a9
Compare
9 tasks
jonasraoni
reviewed
May 8, 2025
jonasraoni
reviewed
May 8, 2025
jonasraoni
approved these changes
May 8, 2025
Co-authored-by: Jonas Raoni Soares da Silva <[email protected]>
ewhanson
requested changes
May 12, 2025
@@ -45,8 +45,7 @@ | |||
{load_url_in_div id="seriesGridContainer" url=$seriesGridUrl} | |||
</tab> | |||
<tab id="categories" label="{translate key="grid.category.categories"}"> | |||
{capture assign=categoriesUrl}{url router=PKP\core\PKPApplication::ROUTE_COMPONENT component="grid.settings.category.CategoryCategoryGridHandler" op="fetchGrid" escape=false}{/capture} | |||
{load_url_in_div id="categoriesContainer" url=$categoriesUrl} | |||
<category-manager v-bind="pageInitConfig"></category-manager> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same question on pageInitConfig
from OJS.
9c5a4c3
to
2156732
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For pkp/pkp-lib#10404