Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add of timeout in waiting gotos #441

Merged
merged 3 commits into from
Nov 4, 2024

Conversation

ClaireHzl
Copy link
Collaborator

Bug of server never assigning an id to a movement (especially when the goto has a small duration)

@ClaireHzl ClaireHzl linked an issue Oct 25, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Oct 25, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
3050 2056 67% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
src/reachy2_sdk/parts/arm.py 30% 🟢
src/reachy2_sdk/parts/goto_based_part.py 30% 🟢
src/reachy2_sdk/parts/head.py 44% 🟢
tests/units/online/test_advanced_goto_functions.py 100% 🟢
TOTAL 51% 🟢

updated for commit: 07a5056 by action🐍

Copy link
Contributor

@FabienDanieau FabienDanieau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solves the issue! I'd would simply a bit the test though

@ClaireHzl ClaireHzl merged commit 69f42c6 into develop Nov 4, 2024
8 checks passed
@ClaireHzl ClaireHzl deleted the 440-infinite-loop-in-blocking-gotos branch November 4, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Infinite loop in blocking gotos
2 participants