Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

507 add gripper to reachyjoints version2 #517

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

glannuzel
Copy link
Member

Grippers are now listed in reachy.joints

Creation of a parallel_gripper element, Hand is now abstract and the type of hand must be specified

@glannuzel glannuzel requested a review from RemiFabre March 13, 2025 13:25
@glannuzel glannuzel linked an issue Mar 13, 2025 that may be closed by this pull request
@glannuzel glannuzel self-assigned this Mar 13, 2025
Copy link

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
4202 2964 71% 0% 🟢

New Files

File Coverage Status
src/reachy2_sdk/grippers/init.py 100% 🟢
src/reachy2_sdk/grippers/gripper_joint.py 94% 🟢
src/reachy2_sdk/grippers/parallel_gripper.py 57% 🟢
tests/units/offline/test_gripper_joint.py 100% 🟢
TOTAL 88% 🟢

Modified Files

File Coverage Status
src/reachy2_sdk/components/antenna.py 66% 🟢
src/reachy2_sdk/orbita/orbita.py 80% 🟢
src/reachy2_sdk/orbita/orbita2d.py 74% 🟢
src/reachy2_sdk/orbita/orbita3d.py 78% 🟢
src/reachy2_sdk/parts/arm.py 39% 🟢
src/reachy2_sdk/parts/hand.py 71% 🟢
src/reachy2_sdk/parts/head.py 55% 🟢
src/reachy2_sdk/parts/part.py 84% 🟢
tests/units/offline/test_arm.py 100% 🟢
tests/units/offline/test_head.py 100% 🟢
tests/units/offline/test_orbita2d.py 100% 🟢
tests/units/offline/test_orbita3d.py 100% 🟢
tests/units/online/test_audit.py 100% 🟢
tests/units/online/test_hand.py 100% 🟢
TOTAL 82% 🟢

updated for commit: 1571ed6 by action🐍

Copy link
Member

@RemiFabre RemiFabre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Did a superficial read of the diffs, everything seems sane.
Ran jupyer notebooks 2 and 3, everything worked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add gripper to reachy.joints
2 participants