Clean up multiplayer related ts interfaces #12191
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
nanaya
commented
May 27, 2025
nanaya
commented
- nullable using actual null instead of optional (undefined)
- use explicit json time function to cast played_at
- add create time to playlist item transformer (to match legacy game start_time)
- remove a few outdated todos
- legacy match score is now based on new format
- I don't think we'll change the mods to use the new format
- conversion will be done frontend side as needed
- fix incorrect playlist item mods related typing
nanaya
force-pushed
the
multiplayer-interface-cleanup
branch
2 times, most recently
from
c7b9de4 to
5011986
Compare
- nullable using actual null instead of optional (undefined)
- fix playlist item played_at casting
- add create time to playlist item transformer (to match legacy game
start_time)
- remove a few outdated todos
- legacy match score is now based on new format
- I don't think we'll change the mods to use the new format
- conversion will be done frontend side as needed
- fix incorrect playlist item mods related typing
- add missing playlist item freestyle attribute typing
nanaya
force-pushed
the
multiplayer-interface-cleanup
branch
from
5011986 to
6cc5d50
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.