check type completeness on all platforms #2767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2767 +/- ##
=======================================
Coverage 98.94% 98.94%
=======================================
Files 113 113
Lines 16843 16843
Branches 3036 3036
=======================================
Hits 16665 16665
Misses 123 123
Partials 55 55 |
|
Not bothering with forcing binary merges on |
A5rocks
reviewed
Aug 21, 2023
| "category": "function", | ||
| "diagnostics": [ | ||
| { | ||
| "file": "/home/h/Git/trio/typing_improvements/.tox/verifytypes/lib/python3.8/site-packages/trio/_core/__init__.py", |
There was a problem hiding this comment.
By the way! Maybe you missed this
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fully type complete, other than docstrings (#2762), on both Mac and Linux! 🎉
Windows still needs works (#2761), but otherwise we're pretty much there wrt to the public API 🚀 🚀