-
-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate trio.__version__
#3190
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3190 +/- ##
===============================================
Coverage 100.00000% 100.00000%
===============================================
Files 124 124
Lines 18460 18538 +78
Branches 1216 1221 +5
===============================================
+ Hits 18460 18538 +78
|
73e8a5f
to
cb3de6a
Compare
I didn't realize that deprecating an attribute means it can't exist as a type hint... If I did I would have just skipped #3186! But oh well. |
it's a shame that https://typing.readthedocs.io/en/latest/spec/directives.html#deprecated (available in typing_extensions) is only meant for classes & functions, but with some messing around it might be possible to make it a Also I guess |
This would require telling the type checker the module got replaced by a class (which I don't think is possible?) Updating conf.py makes sense though. |
This seems unnecessarily churn-y to me and I'm against it. What is the concrete benefit envisioned from removing this attribute? Due to the |
It lets us be a bit more creative with the version (like using a git tag) but I made this PR due to it being a follow up rather than a concrete need. (So I'm fine closing it) (Though IMO the RTD updates of this are actually good and I might cherry pick to another PR) |
But yeah the only benefit would be not having to comply with it in the future, in case we do want to mess around with it. (so yeah I'd also be alright with not changing it) |
Superseded by #3194 which doesn't deprecate |
Follow up to #3186