Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use importlib.metadata in docs build #3194

Merged
merged 2 commits into from
Jan 30, 2025

Conversation

A5rocks
Copy link
Contributor

@A5rocks A5rocks commented Jan 29, 2025

This also makes RTD install trio instead of depending on import trio working. IMO this is more correct.

Supersedes #3190.

Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00000%. Comparing base (ed2a7d3) to head (ad2d101).
Report is 51 commits behind head on main.

Additional details and impacted files
@@                Coverage Diff                @@
##                 main        #3194     +/-   ##
=================================================
  Coverage   100.00000%   100.00000%             
=================================================
  Files             124          124             
  Lines           18460        19619   +1159     
  Branches         1216         1483    +267     
=================================================
+ Hits            18460        19619   +1159     

see 4 files with indirect coverage changes

@CoolCat467 CoolCat467 added this pull request to the merge queue Jan 30, 2025
Merged via the queue into python-trio:main with commit 3b94a1a Jan 30, 2025
39 checks passed
@A5rocks A5rocks deleted the use-importlib-metadata-for-docs branch January 30, 2025 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants