Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add xfail for issue 3209, and start testing Python 3.14 #3211

Merged
merged 4 commits into from
Feb 14, 2025

Conversation

musicinmybrain
Copy link
Contributor

See commit messages and discussion in #3209 for details.

It doesn’t yet "pip install" on 3.14.
Copy link

codecov bot commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00000%. Comparing base (5eb5afb) to head (6b63492).
Report is 5 commits behind head on main.

Additional details and impacted files
@@               Coverage Diff               @@
##                 main        #3211   +/-   ##
===============================================
  Coverage   100.00000%   100.00000%           
===============================================
  Files             124          124           
  Lines           18787        18764   -23     
  Branches         1269         1269           
===============================================
- Hits            18787        18764   -23     
Files with missing lines Coverage Δ
src/trio/_core/_tests/test_run.py 100.00000% <ø> (ø)

@jakkdl
Copy link
Member

jakkdl commented Feb 14, 2025

codecov drop was due to the uploader giving an error 503 https://github.com/python-trio/trio/actions/runs/13333607547/job/37243603393?pr=3211#step:6:43
see #3173

Copy link
Member

@jakkdl jakkdl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happily surprised none of the test_exports tests got upset!

Copy link
Member

@CoolCat467 CoolCat467 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as far as I can tell

@A5rocks A5rocks enabled auto-merge February 14, 2025 20:52
@A5rocks A5rocks added this pull request to the merge queue Feb 14, 2025
@A5rocks A5rocks linked an issue Feb 14, 2025 that may be closed by this pull request
Merged via the queue into python-trio:main with commit d63f3a9 Feb 14, 2025
43 checks passed
@trio-bot
Copy link

trio-bot bot commented Feb 14, 2025

Hey @musicinmybrain, it looks like that was the first time we merged one of your PRs! Thanks so much! 🎉 🎂

If you want to keep contributing, we'd love to have you. So, I just sent you an invitation to join the python-trio organization on Github! If you accept, then here's what will happen:

  • Github will automatically subscribe you to notifications on all our repositories. (But you can unsubscribe again if you don't want the spam.)

  • You'll be able to help us manage issues (add labels, close them, etc.)

  • You'll be able to review and merge other people's pull requests

  • You'll get a [member] badge next to your name when participating in the Trio repos, and you'll have the option of adding your name to our member's page and putting our icon on your Github profile (details)

If you want to read more, here's the relevant section in our contributing guide.

Alternatively, you're free to decline or ignore the invitation. You'll still be able to contribute as much or as little as you like, and I won't hassle you about joining again. But if you ever change your mind, just let us know and we'll send another invitation. We'd love to have you, but more importantly we want you to do whatever's best for you.

If you have any questions, well... I am just a humble Python script, so I probably can't help. But please do post a comment here, or in our chat, or on our forum, whatever's easiest, and someone will help you out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants