Add test for lut based embedding quantization. #2825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

facebook-github-bot merged 2 commits into pytorch:main from szyszyzys:export-D79750022

Aug 23, 2025

Contributor

szyszyzys commented Aug 20, 2025

Summary: Test the group wise lut based quantizated embedding.

Reviewed By: metascroy

Differential Revision: D79750022

pytorch-bot bot commented Aug 20, 2025 •

edited

Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2825

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Cancelled Job, 1 Unrelated Failure

As of commit f451624 with merge base df7bf37 ():

NEW FAILURE - The following job has failed:

Run 1xH100 Tests / test (H100, linux.aws.h100, --pre torch torchvision torchaudio fbgemm-gpu-genai --index-url https... / linux-job (gh)
test/dtypes/test_affine_quantized_float.py::TestAffineQuantizedFloat8Compile::test_expected_kernels_on_gpu_granularity1_float8_config_version_2

CANCELLED JOB - The following job was cancelled. Please retry:

Run TorchAO Experimental Tests / test-cpu-ops (macos-14) (gh)
##[error]The operation was canceled.

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

Run TorchAO Experimental Tests / test-cpu-ops (linux.arm64.2xlarge) (gh) (trunk failure)
/home/ec2-user/actions-runner/_work/ao/ao/torchao/experimental/../../torchao/experimental/ops/embedding_lut/op_embedding_groupwise_lowbit_lut-impl.h:227:50: error: ‘packed_embedding_size’ is not a member of ‘torchao::kernels::cpu::aarch64::embedding’

This comment was automatically generated by Dr. CI and updates every 15 minutes.

meta-cla bot added the CLA Signed label

Contributor

facebook-github-bot commented Aug 20, 2025

This pull request was exported from Phabricator. Differential Revision: D79750022

facebook-github-bot added the fb-exported label

szyszyzys requested a review from metascroy

August 20, 2025 22:46

szyszyzys added the topic: not user facing label

szyszyzys force-pushed the export-D79750022 branch from a27dc46 to 6c08859 Compare

August 21, 2025 16:59

szyszyzys added a commit to szyszyzys/ao that referenced this pull request


          Add test for lut based embedding quantization. (pytorch#2825)

6c08859

Summary:

Test the group wise lut based quantizated embedding.

Reviewed By: metascroy

Differential Revision: D79750022

Contributor

facebook-github-bot commented Aug 21, 2025

This pull request was exported from Phabricator. Differential Revision: D79750022

szyszyzys force-pushed the export-D79750022 branch from 6c08859 to bc22ea7 Compare

August 21, 2025 17:03

szyszyzys added a commit to szyszyzys/ao that referenced this pull request


          Add test for lut based embedding quantization. (pytorch#2825)

bc22ea7

Summary:
Pull Request resolved: pytorch#2825

Test the group wise lut based quantizated embedding.

Reviewed By: metascroy

Differential Revision: D79750022

szyszyzys force-pushed the export-D79750022 branch from bc22ea7 to 13c7b5b Compare

August 21, 2025 17:09

szyszyzys added a commit to szyszyzys/ao that referenced this pull request


          Add test for lut based embedding quantization. (pytorch#2825)

13c7b5b

Summary:

Test the group wise lut based quantizated embedding.

Reviewed By: metascroy

Differential Revision: D79750022

Contributor

facebook-github-bot commented Aug 21, 2025

This pull request was exported from Phabricator. Differential Revision: D79750022

metascroy approved these changes

View reviewed changes

szyszyzys force-pushed the export-D79750022 branch from 13c7b5b to 824ab9e Compare

August 22, 2025 00:40

szyszyzys added a commit to szyszyzys/ao that referenced this pull request


          Add test for lut based embedding quantization. (pytorch#2825)

824ab9e

Summary:

Test the group wise lut based quantizated embedding.

Reviewed By: metascroy

Differential Revision: D79750022

Contributor

facebook-github-bot commented Aug 22, 2025

This pull request was exported from Phabricator. Differential Revision: D79750022

szyszyzys added a commit to szyszyzys/ao that referenced this pull request


          Add test for lut based embedding quantization. (pytorch#2825)

3277d96

Summary:

Test the group wise lut based quantizated embedding.

Reviewed By: metascroy

Differential Revision: D79750022

szyszyzys force-pushed the export-D79750022 branch from 824ab9e to 3277d96 Compare

August 22, 2025 00:47

Contributor

facebook-github-bot commented Aug 22, 2025

This pull request was exported from Phabricator. Differential Revision: D79750022

szyszyzys added a commit to szyszyzys/ao that referenced this pull request


          Add test for lut based embedding quantization. (pytorch#2825)

5e14edf

Summary:

Test the group wise lut based quantizated embedding.

Reviewed By: metascroy

Differential Revision: D79750022

szyszyzys force-pushed the export-D79750022 branch from 3277d96 to 5e14edf Compare

August 22, 2025 00:53

Contributor

facebook-github-bot commented Aug 22, 2025

This pull request was exported from Phabricator. Differential Revision: D79750022

szyszyzys force-pushed the export-D79750022 branch from 5e14edf to 2eb2a6a Compare

August 22, 2025 00:54

szyszyzys added a commit to szyszyzys/ao that referenced this pull request


          Add test for lut based embedding quantization. (pytorch#2825)

2eb2a6a

Summary:

Test the group wise lut based quantizated embedding.

Reviewed By: metascroy

Differential Revision: D79750022

Contributor

facebook-github-bot commented Aug 22, 2025

This pull request was exported from Phabricator. Differential Revision: D79750022

szyszyzys added a commit to szyszyzys/ao that referenced this pull request


          Add test for lut based embedding quantization. (pytorch#2825)

b20f639

Summary:

Test the group wise lut based quantizated embedding.

Reviewed By: metascroy

Differential Revision: D79750022

szyszyzys force-pushed the export-D79750022 branch from 2eb2a6a to b20f639 Compare

August 22, 2025 00:56

Contributor

facebook-github-bot commented Aug 22, 2025

This pull request was exported from Phabricator. Differential Revision: D79750022


          Add lut quantized embedding. (pytorch#2824)

22c5772

Summary: Pull Request resolved: pytorch#2824

Differential Revision: D79750002

Reviewed By: metascroy

szyszyzys force-pushed the export-D79750022 branch from b20f639 to 66a5ec0 Compare

August 22, 2025 02:01

szyszyzys added a commit to szyszyzys/ao that referenced this pull request


          Add test for lut based embedding quantization. (pytorch#2825)

66a5ec0

Summary:

Test the group wise lut based quantizated embedding.

Reviewed By: metascroy

Differential Revision: D79750022

szyszyzys added a commit to szyszyzys/ao that referenced this pull request


          Add test for lut based embedding quantization. (pytorch#2825)

75e2eba

Summary:

Test the group wise lut based quantizated embedding.

Reviewed By: metascroy

Differential Revision: D79750022

szyszyzys force-pushed the export-D79750022 branch from 66a5ec0 to 75e2eba Compare

August 22, 2025 02:01

Contributor

facebook-github-bot commented Aug 22, 2025

This pull request was exported from Phabricator. Differential Revision: D79750022


          Add test for lut based embedding quantization. (pytorch#2825)

f451624

Summary:
Pull Request resolved: pytorch#2825

Test the group wise lut based quantizated embedding.

Reviewed By: metascroy

Differential Revision: D79750022

Contributor

facebook-github-bot commented Aug 22, 2025

This pull request was exported from Phabricator. Differential Revision: D79750022

szyszyzys force-pushed the export-D79750022 branch from 75e2eba to f451624 Compare

August 22, 2025 02:05

meta-cla bot commented Aug 23, 2025

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot merged commit 98e406d into pytorch:main

15 of 20 checks passed

liangel-02 pushed a commit that referenced this pull request


          Add test for lut based embedding quantization.

3b022db

Differential Revision: D79750022

Pull Request resolved: #2825

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed fb-exported topic: not user facing