Skip to content

Conversation

@yinrun
Copy link

@yinrun yinrun commented Nov 26, 2025

Add SM8850 for QualComm Snapdragon 8 Elite Gen 5.

Summary

Fixes #15986

Test plan

python -m examples.qualcomm.oss_scripts.llama.llama -b build-android -m SM8850 --temperature 0 --model_mode kv --max_seq_len 512 --prefill_ar_len 64 --decoder_model qwen3-0_6b --prompt "你好,请介绍一
下人工智能" --compile_only

@yinrun yinrun requested a review from cccclai as a code owner November 26, 2025 06:23
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 26, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15987

Note: Links to docs will display an error until the docs builds have been completed.

❗ 2 Active SEVs

There are 2 currently active SEVs. If your PR is affected, please view them below:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla
Copy link

meta-cla bot commented Nov 26, 2025

Hi @yinrun!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 26, 2025
Copy link
Collaborator

@shewu-quic shewu-quic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contribution.
Could you please also add SM8850 in README.md?

Thanks

@cccclai
Copy link
Contributor

cccclai commented Nov 26, 2025

Thank you for contributing! Can you also sign the CLA as described in the comment here

Hi @yinrun!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

Add SM8850 for QualComm Snapdragon 8 Elite Gen 5.
@yinrun
Copy link
Author

yinrun commented Nov 27, 2025

Thanks for contribution. Could you please also add SM8850 in README.md?

Thanks

Okay, I have already add "Snapdragon 8 Elite Gen 5" in section Supported Chipset.
image

@shewu-quic

@yinrun
Copy link
Author

yinrun commented Nov 27, 2025

and we don't seem to have one on file for you.

It's done. Thanks for the reminder.

image

@cccclai

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[QNN] QualComm latest SM8850 doesn't support

3 participants