[viable/strict] Ignore failing jobs with unstable issues #6362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
facebook-github-bot
added
the
CLA Signed
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
malfet
approved these changes
Mar 5, 2025
ZainRizvi
approved these changes
Mar 5, 2025
Camyll
pushed a commit
that referenced
this pull request
Mar 8, 2025
Allows the viable strict promotion script to use unstable issues. Jobs that have unstable issues open will be ignored in viable strict promotion. Tested with 0ef2e938d0a9a4b90434f98b5e128d0ffacaae26 (passed, only thing failing is libtorch debug build which has an issue right now) 96afa8a2bb78e5410a83038fd1e3f83911601700 (failed since there's something pending) c5d92edd5acfa56bae4f0c1057d667c6356fd6c1 (failed since lint failed)
malfet
pushed a commit
that referenced
this pull request
Mar 19, 2025
Follow up to #6362, I forgot that the format is slightly different for test jobs due to the shards Tested by running on a couple of commits pytorch. Checked that executorch test config (currently has an issue) got ignored Checked that commit with trunk job failing was correctly marked as red
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows the viable strict promotion script to use unstable issues. Jobs that have unstable issues open will be ignored in viable strict promotion.
Tested with
0ef2e938d0a9a4b90434f98b5e128d0ffacaae26 (passed, only thing failing is libtorch debug build which has an issue right now)
96afa8a2bb78e5410a83038fd1e3f83911601700 (failed since there's something pending)
c5d92edd5acfa56bae4f0c1057d667c6356fd6c1 (failed since lint failed)