Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change branching logic to enable caching again + rename vcf2mat to vcf2counts #24

Merged
merged 16 commits into from
Feb 10, 2025

Conversation

famosab
Copy link
Collaborator

@famosab famosab commented Feb 5, 2025

Previously a branching mutated the meta maps which led to caching being disabled (when runnign with -resume). This PR fixes that and renames one module to match the script name.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@famosab famosab changed the title Change branching logic to enable caching again Change branching logic to enable caching again + rename vcf2mat to vcf2counts Feb 6, 2025
Copy link
Contributor

@d4straub d4straub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont understand why that PR adds another process.

@famosab
Copy link
Collaborator Author

famosab commented Feb 7, 2025

I dont understand why that PR adds another process.

I somehow was not able to create the files without ruining the caching (eg -resume did not recover cached files for everthing after the creation of these "samplefiles").

Copy link
Contributor

@d4straub d4straub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@famosab famosab merged commit 0a0c3a1 into qbic-pipelines:dev Feb 10, 2025
7 checks passed
@famosab famosab deleted the fix/branching branch February 10, 2025 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants