Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename pipeline to VCFTOCOUNTS + Prepare Release 2.0.0 #25

Merged
merged 6 commits into from
Feb 11, 2025

Conversation

famosab
Copy link
Collaborator

@famosab famosab commented Feb 6, 2025

I want to change the pipeline name to VCFTOCOUNTS because this is less likely to be confused with the VCFTOMAF pipeline and it reflects the name of the key module (which has the script vcf2counts.R).

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@famosab famosab changed the title Rename pipeline to VCFTOCOUNTS + Peprare Release 2.0.0 Rename pipeline to VCFTOCOUNTS + Prepare Release 2.0.0 Feb 6, 2025
Copy link
Contributor

@mapo9 mapo9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite certain, that I'll never forget the name of the pipeline now...

LGTM 🚀

@@ -1,20 +1,20 @@
# `qbic-pipelines/vcftomat`: Contributing Guidelines
# `qbic-pipelines/vcftocounts`: Contributing Guidelines
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

finally. like the name way better!

@famosab famosab merged commit bff4e4d into qbic-pipelines:dev Feb 11, 2025
7 checks passed
@famosab famosab deleted the rel-2.0.0 branch February 11, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants