Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move test data to test-datasets, create filter nf-test #28

Merged
merged 3 commits into from
Feb 12, 2025
Merged

Move test data to test-datasets, create filter nf-test #28

merged 3 commits into from
Feb 12, 2025

Conversation

famosab
Copy link
Collaborator

@famosab famosab commented Feb 12, 2025

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

mapo9
mapo9 reviewed Feb 12, 2025
View reviewed changes
Copy link
Contributor

@mapo9 mapo9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@famosab @mapo9
Update CHANGELOG.md
0e608c7 
Co-authored-by: Mark Polster <[email protected]>
@famosab famosab merged commit a308ff8 into qbic-pipelines:dev Feb 12, 2025
7 checks passed
@famosab famosab deleted the fixes-before-2.0.0 branch February 12, 2025 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mapo9 mapo9 mapo9 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@famosab @mapo9