Skip to content

Update Derby to 10.16.1.2 #50706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update Derby to 10.16.1.2 #50706

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bom/application/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@
<mssql-jdbc.version>13.2.1.jre11</mssql-jdbc.version>
<adal4j.version>1.6.7</adal4j.version>
<oracle-jdbc.version>23.6.0.24.10</oracle-jdbc.version>
<derby-jdbc.version>10.16.1.1</derby-jdbc.version>
<derby-jdbc.version>10.16.1.2</derby-jdbc.version>
<db2-jdbc.version>12.1.0.0</db2-jdbc.version>
<shrinkwrap.version>1.2.6</shrinkwrap.version>
<hamcrest.version>2.2</hamcrest.version><!-- The version needs to be compatible with both REST Assured and Awaitility -->
Expand Down
11 changes: 11 additions & 0 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,17 @@
<enabled>false</enabled>
</snapshots>
</repository>
<repository>
<id>nordix-artifactory</id>
<url>https://artifactory.nordix.org/artifactory/allies</url>
<name>allies</name>
<releases>
<enabled>true</enabled>
</releases>
<snapshots>
<enabled>true</enabled>
</snapshots>
</repository>
Comment on lines +153 to +163
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want this change :).

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would adding the jars locally be an acceptable alternative?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The jars are not on Maven Central?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't really depend on jars from external repository that are not vetted.

If 10.17.1.0 is safer, it's probably the best option as it's available on Maven Central. But... IIRC, there were issues with it so it might need some additional work.

From what I can see, Derby doesn't look very well maintained.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I remember the issue now, Derby 10.17 is Java 21+ and we are still supporting Java 17.

I wonder if we should extract this extension to the Quarkiverse and let it live there with its own requirements. Or update to 10.17 and disable build/testing for this extension on Java 17.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, why are you using Derby?

What do you mean?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, apparently, it's not really maintained anymore so I was wondering why you chose to use it. We discussed a few times dropping it from the repository so it would help to know why people are still using it.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not using it for anything specific. I'm just tyring to resolve the CVE

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I started a discussion here: https://groups.google.com/g/quarkus-dev/c/NRSpQYVlz_Y .

Copy link
Author

@eschcam eschcam Oct 24, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I started a discussion here: https://groups.google.com/g/quarkus-dev/c/NRSpQYVlz_Y .

I'll do my best to keep an eye on it.
Please let me know of any changes you need me to make to this PR

</repositories>

<build>
Expand Down