-
Couldn't load subscription status.
- Fork 3k
Update Derby to 10.16.1.2 #50706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Derby to 10.16.1.2 #50706
Conversation
Derby 10.16.1.1 contains CVE-2022-46337.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, there's something off in the PR though. Can you fix and squash? Thanks!
| <repository> | ||
| <id>nordix-artifactory</id> | ||
| <url>https://artifactory.nordix.org/artifactory/allies</url> | ||
| <name>allies</name> | ||
| <releases> | ||
| <enabled>true</enabled> | ||
| </releases> | ||
| <snapshots> | ||
| <enabled>true</enabled> | ||
| </snapshots> | ||
| </repository> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't want this change :).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would adding the jars locally be an acceptable alternative?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The jars are not on Maven Central?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't really depend on jars from external repository that are not vetted.
If 10.17.1.0 is safer, it's probably the best option as it's available on Maven Central. But... IIRC, there were issues with it so it might need some additional work.
From what I can see, Derby doesn't look very well maintained.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I remember the issue now, Derby 10.17 is Java 21+ and we are still supporting Java 17.
I wonder if we should extract this extension to the Quarkiverse and let it live there with its own requirements. Or update to 10.17 and disable build/testing for this extension on Java 17.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of curiosity, why are you using Derby?
What do you mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, apparently, it's not really maintained anymore so I was wondering why you chose to use it. We discussed a few times dropping it from the repository so it would help to know why people are still using it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not using it for anything specific. I'm just tyring to resolve the CVE
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I started a discussion here: https://groups.google.com/g/quarkus-dev/c/NRSpQYVlz_Y .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I started a discussion here: https://groups.google.com/g/quarkus-dev/c/NRSpQYVlz_Y .
I'll do my best to keep an eye on it.
Please let me know of any changes you need me to make to this PR
|
Unfortunately using a different repository is a no-go, so I'm closing this one |
Derby 10.16.1.1 contains CVE-2022-46337