More minor fixes for CCCL #17793
Open
More minor fixes for CCCL #17793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdice
approved these changes
Jan 23, 2025
| // types are returned as is. | ||
| template <typename T, bool has_nulls> | ||
| struct possibly_null_value; | ||
|
|
||
| template <typename T> | ||
| struct possibly_null_value<T, true> { | ||
| using type = thrust::optional<T>; | ||
| using type = cuda::std::optional<T>; |
There was a problem hiding this comment.
Here, I might have answered it myself. #15091 (comment)
Device uses of
thrust::optionalcan be replaced withcuda::std::optionalin a future PR, once we upgrade to CCCL 2.3 or newer
Is that why?
There was a problem hiding this comment.
Nope. We saw test failures with cuda::std::optional here. #15091 (comment)
There was a problem hiding this comment.
Same failures appear again, there is definitely something fishy going on
davidwendt
added
3 - Ready for Review
davidwendt
approved these changes
Jan 23, 2025
rapids-bot bot
pushed a commit
that referenced
this pull request
Feb 5, 2025
This avoids failures in CCCL CI Pulled out of #17793 Authors: - Michael Schellenberger Costa (https://github.com/miscco) - Bradley Dice (https://github.com/bdice) Approvers: - Bradley Dice (https://github.com/bdice) - David Wendt (https://github.com/davidwendt) - James Lamb (https://github.com/jameslamb) URL: #17911
|
I updated this PR now that #17911 is in. It's down to just the AST optional that doesn't seem to work if it's changed from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This drops the final use of
thrust::optionalin cuDF