RDKECMF-233 testing workflows. DO NOT MERGE. #1
Conversation
scthunderbolt
changed the title
| @@ -11128,7 +11128,7 @@ | |||
| { | |||
| std::string tmedia = media; | |||
| TileInfo tileInfo; | |||
| memset( &tileInfo,0,sizeof(tileInfo) ); | |||
| memset( &tileInfo,0,10*sizeof(tileInfo) ); | |||
There was a problem hiding this comment.
Coverity Issue - Out-of-bounds access
Overrunning struct type TileInfo of 64 bytes by passing it to a function which accesses it at byte offset 639 using argument "640UL".
High Impact, CWE-119
OVERRUN
| @@ -11128,7 +11128,7 @@ | |||
| { | |||
| std::string tmedia = media; | |||
| TileInfo tileInfo; | |||
| memset( &tileInfo,0,sizeof(tileInfo) ); | |||
| memset( &tileInfo,0,10*sizeof(tileInfo) ); | |||
There was a problem hiding this comment.
Coverity Issue - Wrong sizeof argument
Passing argument "&tileInfo" of type "TileInfo *" and argument "640UL" ("10UL * 64UL") to function "memset" is suspicious because "sizeof (TileInfo) /64/" is expected.
Medium Impact, CWE-131
SIZEOF_MISMATCH
Coverity Issue - Dereference after null checkDereferencing null pointer "delta". Medium Impact, CWE-476 Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Coverity Issue - Data race conditionAccessing "this->mDiscontinuityTuneOperationInProgress" without holding lock "PrivateInstanceAAMP.mLock". Elsewhere, "PrivateInstanceAAMP.mDiscontinuityTuneOperationInProgress" is written to with "PrivateInstanceAAMP.mLock" held 4 out of 4 times (2 of these accesses strongly imply that it is necessary). Medium Impact, CWE-366 Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Coverity Issue - Variable copied when it could be moved"textTrack" is copied and then passed-by-reference as parameter to STL insertion function "std::vector<TextTrackInfo, std::allocator >::push_back(std::vector<TextTrackInfo, std::allocator >::value_type const &)", when it could be moved instead. Low Impact, CWE-none How to fixUse "std::move(""textTrack"")" instead of "textTrack". Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Coverity Issue - Data race conditionAccessing "this->mDownloadsEnabled" without holding lock "PrivateInstanceAAMP.mLock". Elsewhere, "PrivateInstanceAAMP.mDownloadsEnabled" is written to with "PrivateInstanceAAMP.mLock" held 2 out of 2 times (2 of these accesses strongly imply that it is necessary). Medium Impact, CWE-366 Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Coverity Issue - Data race conditionAccessing "this->mCdaiObject->mCurAdIdx" without holding lock "PrivateCDAIObjectMPD.mDaiMtx". Elsewhere, "PrivateCDAIObjectMPD.mCurAdIdx" is written to with "PrivateCDAIObjectMPD.mDaiMtx" held 9 out of 9 times (1 of these accesses strongly imply that it is necessary). Medium Impact, CWE-366 Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Coverity Issue - Dereference after null checkPassing null pointer "mediaTrack" to "GetBufferedDuration", which dereferences it. (The dereference happens because this is a virtual function call.) Medium Impact, CWE-476 Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Coverity Issue - Variable copied when it could be moved"textTrack" is copied and then passed-by-reference as parameter to STL insertion function "std::vector<TextTrackInfo, std::allocator >::push_back(std::vector<TextTrackInfo, std::allocator >::value_type const &)", when it could be moved instead. Low Impact, CWE-none How to fixUse "std::move(""textTrack"")" instead of "textTrack". Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Coverity Issue - Dereference after null checkDereferencing null pointer "http_error". Medium Impact, CWE-476 Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Coverity Issue - Variable copied when it could be moved"textTrack" is copied and then passed-by-reference as parameter to STL insertion function "std::vector<TextTrackInfo, std::allocator >::push_back(std::vector<TextTrackInfo, std::allocator >::value_type const &)", when it could be moved instead. Low Impact, CWE-none How to fixUse "std::move(""textTrack"")" instead of "textTrack". Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Coverity Issue - Data race conditionA wait is performed without a loop. If there is a spurious wakeup, the condition may not be satisfied. Medium Impact, CWE-none How to fixCheck the wait condition in a loop, with the lock held. The lock must not be released between the condition and the wait. Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
No description provided.