Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RDKECMF-233 testing workflows. DO NOT MERGE. #1

Closed
wants to merge 7 commits into from
Closed

RDKECMF-233 testing workflows. DO NOT MERGE. #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0360839
RDKECMF-233 testing workflows
jamcoole Jan 21, 2025
1c1d6d5
Use open docker-rdk-ci container in L1-tests
scthunderbolt Jan 21, 2025
da10c16
Update run and upload steps in L1-tests
scthunderbolt Jan 21, 2025
b8e5cca
Update run step in L1-tests
scthunderbolt Jan 21, 2025
ae10603
Create Coverity issue to test workflow
scthunderbolt Jan 21, 2025
a3ee2fa
Merge branch 'develop' into feature/test-workflows
scthunderbolt Feb 17, 2025
e3501ed
TEST. DO NOT MERGE
scthunderbolt Feb 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions .github/workflows/L1-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,14 @@ env:
AUTOMATICS_UNAME: ${{ secrets.AUTOMATICS_UNAME }}
AUTOMATICS_PASSCODE: ${{ secrets.AUTOMATICS_PASSCODE }}
WORKSPACE: ${{ github.workspace }}
CI_CONTAINER: ${{ secrets.CI_CONTAINER }}
TEST_RESULTS_SERVER: ${{ secrets.TEST_RESULTS_SERVER }}

jobs:
execute-unit-tests-on-pr:
name: Execute unit tests in gtest test suite
runs-on: ubuntu-latest
container:
image: ${{ env.CI_CONTAINER }}
image: ghcr.io/rdkcentral/docker-rdk-ci:latest

steps:
- name: Checkout aamp code
Expand All @@ -25,10 +24,10 @@ jobs:
path: aamp

- name: Run unit tests
if: env.CI_CONTAINER != ''
run: /bin/bash aamp/test/run_ut.sh
run: sh -c test/run_ut.sh

- name: Upload test results to automatic test result management system
if: env.CI_CONTAINER != ''
run: >
gtest-json-result-push.py /tmp/Gtest_Report ${{ env.TEST_RESULTS_SERVER }} `pwd`
if: github.repository_owner == 'rdkcentral'
run: |
git config --global --add safe.directory `pwd`
gtest-json-result-push.py /tmp/Gtest_Report ${{ env.TEST_RESULTS_SERVER }} `pwd`
2 changes: 1 addition & 1 deletion fragmentcollector_mpd.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* If not stated otherwise in this file or this component's license file the

Check failure on line 2 in fragmentcollector_mpd.cpp

View workflow job for this annotation

GitHub Actions / call-fossid-workflow / Fossid Annotate PR

FossID License Issue Detected 

Source code with 'Apache-2.0' license found in local file 'fragmentcollector_mpd.cpp' (Match: haltersweb/aamp/9b34e03c6766cdfb8ce444f72f4665656dc52fbc, 12030 lines, url: https://github.com/haltersweb/aamp/archive/9b34e03c6766cdfb8ce444f72f4665656dc52fbc.tar.gz, file: fragmentcollector_mpd.cpp)

Check failure on line 2 in fragmentcollector_mpd.cpp

View workflow job for this annotation

GitHub Actions / call-fossid-workflow / Fossid Annotate PR

FossID License Issue Detected 

Source code with 'Apache-2.0' license found in local file 'fragmentcollector_mpd.cpp' (Match: rdkcmf/rdk-aamp/1.23, 11459 lines, url: https://github.com/rdkcmf/rdk-aamp/archive/AVS_1.23.tar.gz, file: fragmentcollector_mpd.cpp)

Check failure on line 2 in fragmentcollector_mpd.cpp

View workflow job for this annotation

GitHub Actions / call-fossid-workflow / Fossid Annotate PR

FossID License Issue Detected 

Source code with 'Apache-2.0' license found in local file 'fragmentcollector_mpd.cpp' (Match: rdkcmf/rdk-aamp/4.5.1.0, 11867 lines, url: https://github.com/rdkcmf/rdk-aamp/archive/4.5.1.0.tar.gz, file: fragmentcollector_mpd.cpp)

Check failure on line 2 in fragmentcollector_mpd.cpp

View workflow job for this annotation

GitHub Actions / call-fossid-workflow / Fossid Annotate PR

FossID License Issue Detected 

Source code with 'Apache-2.0' license found in local file 'fragmentcollector_mpd.cpp' (Match: rdkcmf/rdk-aamp/4.2.2.0, 12444 lines, url: https://github.com/rdkcmf/rdk-aamp/archive/4.2.2.0.tar.gz, file: fragmentcollector_mpd.cpp)

Check failure on line 2 in fragmentcollector_mpd.cpp

View workflow job for this annotation

GitHub Actions / call-fossid-workflow / Fossid Annotate PR

FossID License Issue Detected 

Source code with 'Apache-2.0' license found in local file 'fragmentcollector_mpd.cpp' (Match: rdkcmf/rdk-aamp/3.5.9.0, 12568 lines, url: https://github.com/rdkcmf/rdk-aamp/archive/3.5.9.0.tar.gz, file: fragmentcollector_mpd.cpp)
* following copyright and licenses apply:
*
* Copyright 2018 RDK Management
Expand Down Expand Up @@ -11159,7 +11159,7 @@
{
std::string tmedia = media;
TileInfo tileInfo;
memset( &tileInfo,0,sizeof(tileInfo) );
memset( &tileInfo,0,10*sizeof(tileInfo) );
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverity Issue - Out-of-bounds access

Overrunning struct type TileInfo of 64 bytes by passing it to a function which accesses it at byte offset 639 using argument "640UL".

High Impact, CWE-119
OVERRUN

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverity Issue - Wrong sizeof argument

Passing argument "&tileInfo" of type "TileInfo *" and argument "640UL" ("10UL * 64UL") to function "memset" is suspicious because "sizeof (TileInfo) /64/" is expected.

Medium Impact, CWE-131
SIZEOF_MISMATCH

tileInfo.startTime = startTime + ( adDuration / timeScale) ;
AAMPLOG_TRACE("timeLineIndex[%d] size [%zu] updated durationMs[%" PRIu64 "] startTime:%f adDuration:%f repeatCount:%d", timeLineIndex, timelines.size(), durationMs, startTime, adDuration, repeatCount);

Expand Down
Loading